Feature/jzettle sedfilter #778
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 21, 2024 22:14
…ettings, specifcally for the ind0 gain value
…ter around a defined rectangular region representing the unsimulated induction1 wire gap
6 tasks
Contributor
|
this PR has a large number of conflicts in packages I don't think are intended to be changed |
jzennamo
reviewed
Dec 4, 2024
|
|
||
| icarus_simwire_wirecell_filtersed: @local::icarus_simwire_wirecell | ||
| icarus_simwire_wirecell_filtersed.wcls_main.configs: ["pgrapher/experiment/icarus/wcls-multitpc-sim-drift-simchannel-refactored-filtersed.jsonnet"] | ||
|
|
Contributor
There was a problem hiding this comment.
Shouldn't this be in a new fcl or shouldn't the detsim fcl also be modified to run the filter module?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A request that this PR is really geared towards a patch release of icaruscode v09_89_01_01p03 for ICARUS systematics. We can include it here for continued functionality in develop, but I need a patch release (github doesn't let me do it or I am not git-savvy enough to have found it quickly). With the other changes here I do not want this currently merged into develop while we figure out more broadly how to include the other pieces of this
Description
Please provide a detailed description of the changes this pull request introduces. If available, also link to a docdb link where the issue/change have been presented on/discussed.
This pull request introduces a larsoft module that can be run during the detsim stage to filter out SimEnergyDeposits around a rectangular volume and creates a new SimEnergyDeposit collection (with a different name, sedfilter) that can be passed to the downstream WireCell processing. The goal of this is to allow for a systematic variation sample that addresses the fact that the induction 1 wire gap at z = 0 is not simulated in the icarus geometry. This PR does not change anything with the standard ICARUS or SBND simulation and the module is completely optional to include.
This PR addresses the fcl configuration and WireCell configuration options of running it as a variation sample and a companion PR in sbncode (SBNSoftware/sbncode#486) addresses the module itself.
Have you added a label? (bug/enhancement/physics etc.)
yes
Have you assigned at least 1 reviewer?
yes
Is this PR related to an open issue / project?
yes, for ICARUS systematics studies for the first oscillation analysis, #769
Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
no
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
yes, there is a companion PR for icaruscode that includes fcl files and wirecell configuration options in order to run this as a systematic variation
Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.
no, this is largely my own work with discussions with @jzennamo