Feature/jzettle sedfilter #487
Conversation
This now lives in `sbndcode`
to follow alphabetical order, improve logging.
…vmpr Delete sbncode/EventGenerator/MultiPart/multipartvertex_sbnd.fcl
…mForTrigger Add ability to shift sim::AuxDetIDEs by the trigger time.
sbncode v09_89_01 for larsoft v09_89_01
…region in order to assess systematics on unsimulated hardware in ICARUS
jzettle
requested review from
PetrilloAtWork,
SFBayLaser,
acampani,
amenegol,
jzennamo and
mvicenzi
and removed request for
mvicenzi
| const int origID = inSimEDep.OrigTrackID(); | ||
|
|
||
| pSimEDeps->push_back(sim::SimEnergyDeposit(numphotons, | ||
| pSimEDeps->emplace_back(sim::SimEnergyDeposit(numphotons, |
There was a problem hiding this comment.
Curiosity: why was this changed? I guess it's unrelated to the trigger time shift.
There was a problem hiding this comment.
I am unfamiliar with this specific module. I did not attempt to change anything and am a little perplexed why there would be changes in other places. I will try to figure out if this is the correct branch to make this PR against (this was the closest thing I saw to v09_89_01).
There was a problem hiding this comment.
If your initial work was against the develop branch then when you rebased to the release it likely saw this as a change and included it. I would cherry pick out only your specific changes and start with a clean version of code on the release/SBN2024A branch (but see later comment).
|
Question for probably @ibsafa but not completely sure? Is this the correct release branch to make a pull request for in order to pull request against v09_89_01_01 and then patch that once this is approved for ICARUS systematic variation studies? This branch seems older than that but I did not see a direct release/v09_89_01_01 branch I could make a PR against. This one has commits included in my PR that I did not expect to be different with the modules I changed from the tagged v09_89_01_01. The last two commits are the ones I made specifically targeting the changes I wanted for PR. |
|
I intend to close this pull request as I created one against a branch of the tag release v09_89_01_01. We might want to explore this release/SBN2024A branch more, but it is not needed for this work |
| product version qual flags <table_format=2> | ||
| genie_xsec v3_04_00 - | ||
| larcv2 v2_2_6 - | ||
| larsoft v09_88_00 - |
There was a problem hiding this comment.
Are you really intending to change the version of LArSoft?
I would like this as a patch to sbncode v09_89_01_01 and I think this release/SBN2024A is the branch for that? Can somebody confirm before any work is done here?
Description
Please provide a detailed description of the changes this pull request introduces. If available, also link to a docdb link where the issue/change have been presented on/discussed.
This pull request introduces a larsoft module that can be run during the detsim stage to filter out SimEnergyDeposits around a rectangular volume and creates a new SimEnergyDeposit collection (with a different name, sedfilter) that can be passed to the downstream WireCell processing. The goal of this is to allow for a systematic variation sample that addresses the fact that the induction 1 wire gap at z = 0 is not simulated in the icarus geometry. This PR does not change anything with the standard ICARUS or SBND simulation and the module is completely optional to include.
This PR addresses the module and a companion PR in icaruscode (SBNSoftware/icaruscode#778) addresses the fcl configuration and WireCell configuration options of running it as a variation sample.
Have you added a label? (bug/enhancement/physics etc.)
yes
Have you assigned at least 1 reviewer?
yes
Is this PR related to an open issue / project?
yes, for ICARUS systematics studies for the first oscillation analysis, SBNSoftware/icaruscode#769
Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
no
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
yes, there is a companion PR for icaruscode that includes fcl files and wirecell configuration options in order to run this as a systematic variation
Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.
no, this is largely my own work with discussions with @jzennamo