Skip to content

Deprecate and fix categorization - #941

Merged
GilMM27 merged 6 commits into
mainfrom
hri-fix-categorization
May 22, 2026
Merged

Deprecate and fix categorization#941
GilMM27 merged 6 commits into
mainfrom
hri-fix-categorization

Conversation

@GilMM27

@GilMM27 GilMM27 commented May 11, 2026

Copy link
Copy Markdown
Contributor
  • Deprecated dynamic categorization via LLM
  • categorize_objects refactored to:
  1. Analyzes Current Shelves: It first scans all shelves to see what they already contain and
    maps existing objects to their semantic categories (e.g., "Shelf 1 has 'apple', so it's
    for 'fruit'").
  2. Groups Table Objects: It takes the list of objects from the table and groups them by
    their specific categories.
  3. Prioritizes Existing Categories: If a table object belongs to a category already present
    on a shelf, it is automatically assigned to that same shelf.
  4. Distributes New Categories:
    4.1. To Empty Shelves: If a category is new, it looks for empty shelves and distributes
    them using a "round-robin" approach to keep things organized.
    4.2. To Occupied Shelves (Overflow): If no empty shelves are left, it distributes the
    remaining new categories across all available shelves.
  5. Avoids Generic Labels: Instead of using "miscellaneous," it returns the actual specific
    category names.
  6. Multi-Category Support: It allows a single shelf to hold multiple categories (e.g.,
    "fruit food"), providing the robot with a precise list of what is stored where.
  • try catch block for extract data requests, before the node just crashed

@GilMM27
GilMM27 marked this pull request as ready for review May 19, 2026 17:34
@GilMM27
GilMM27 requested review from a team as code owners May 19, 2026 17:34
@Oscar-gg

Copy link
Copy Markdown
Member

Depricated -> Deprecated

@Oscar-gg Oscar-gg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 🚀

"0": {"category": "drink", "objects_to_add": ["milk", "fanta"]},
"1": {"category": "dish", "objects_to_add": ["fork"]},
"2": {"category": "miscellaneous", "objects_to_add": ["tangerine", "ketchup"]}
"2": {"category": ["food", "fruit"], "objects_to_add": ["tangerine", "ketchup"]}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could always have an array (even for shelves with one category)?

@GilMM27 GilMM27 changed the title Depricate and fix categorization Deprecate and fix categorization May 22, 2026
@GilMM27
GilMM27 merged commit f0245b9 into main May 22, 2026
6 checks passed
@GilMM27
GilMM27 deleted the hri-fix-categorization branch May 22, 2026 15:04
CamilaTite26 pushed a commit that referenced this pull request May 23, 2026
* remove dynamic categorization  and fix deterministic

* handle multiple categories per shelf

* use different json

* restore objects.json

* standardized list
CamilaTite26 pushed a commit that referenced this pull request May 23, 2026
* remove dynamic categorization  and fix deterministic

* handle multiple categories per shelf

* use different json

* restore objects.json

* standardized list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants