Deprecate and fix categorization - #941
Merged
Merged
Conversation
GilMM27
marked this pull request as ready for review
May 19, 2026 17:34
Member
|
Depricated -> Deprecated |
Oscar-gg
approved these changes
May 22, 2026
| "0": {"category": "drink", "objects_to_add": ["milk", "fanta"]}, | ||
| "1": {"category": "dish", "objects_to_add": ["fork"]}, | ||
| "2": {"category": "miscellaneous", "objects_to_add": ["tangerine", "ketchup"]} | ||
| "2": {"category": ["food", "fruit"], "objects_to_add": ["tangerine", "ketchup"]} |
Member
There was a problem hiding this comment.
Maybe we could always have an array (even for shelves with one category)?
CamilaTite26
pushed a commit
that referenced
this pull request
May 23, 2026
* remove dynamic categorization and fix deterministic * handle multiple categories per shelf * use different json * restore objects.json * standardized list
CamilaTite26
pushed a commit
that referenced
this pull request
May 23, 2026
* remove dynamic categorization and fix deterministic * handle multiple categories per shelf * use different json * restore objects.json * standardized list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
categorize_objectsrefactored to:maps existing objects to their semantic categories (e.g., "Shelf 1 has 'apple', so it's
for 'fruit'").
their specific categories.
on a shelf, it is automatically assigned to that same shelf.
4.1. To Empty Shelves: If a category is new, it looks for empty shelves and distributes
them using a "round-robin" approach to keep things organized.
4.2. To Occupied Shelves (Overflow): If no empty shelves are left, it distributes the
remaining new categories across all available shelves.
category names.
"fruit food"), providing the robot with a precise list of what is stored where.