Skip to content

Adding TBB to sysdeps #4410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ajanicijamd wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Adding TBB to sysdeps #4410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7409196
Adding TBB to third-party/sysdeps
ajanicijamd Apr 8, 2026
c46fc49
Removed dependency of therock-third-party on therock-tbb
ajanicijamd Apr 8, 2026
2d5d546
Disabled AMDGPU targets for TBB
ajanicijamd Apr 8, 2026
0f46f48
Set THEROCK_BUNDLED_TBB; added copyright notice
ajanicijamd Apr 8, 2026
31926e3
Set target property to disable AMDGPU for TBB
ajanicijamd Apr 8, 2026
54576f4
Added USE_DIST_AMDGPU_TARGETS to therock-tbb subproject declaration
ajanicijamd Apr 8, 2026
a01e8ef
Removed ARG_DISABLE_AMDGPU_TARGETS property
ajanicijamd Apr 8, 2026
147fb10
Addressed review comments
ajanicijamd Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,7 @@ set(THEROCK_BUNDLED_MPFR)
set(THEROCK_BUNDLED_NCURSES)
set(THEROCK_BUNDLED_NUMACTL)
set(THEROCK_BUNDLED_SQLITE3)
set(THEROCK_BUNDLED_TBB)
set(THEROCK_BUNDLED_ZLIB)
set(THEROCK_BUNDLED_ZSTD)
set(THEROCK_BUNDLED_AMDMESA)
Expand Down Expand Up @@ -402,6 +403,7 @@ if(THEROCK_BUNDLE_SYSDEPS)
set(THEROCK_BUNDLED_NCURSES therock-ncurses)
set(THEROCK_BUNDLED_NUMACTL therock-numactl)
set(THEROCK_BUNDLED_SQLITE3 therock-sqlite3)
set(THEROCK_BUNDLED_TBB therock-tbb)
set(THEROCK_BUNDLED_ZLIB therock-zlib)
set(THEROCK_BUNDLED_ZSTD therock-zstd)
if(THEROCK_ENABLE_SYSDEPS_AMD_MESA)
Expand Down
2 changes: 1 addition & 1 deletion profiler/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,6 @@ if(THEROCK_ENABLE_ROCPROFV3)
CMAKE_ARGS
-DHIP_PLATFORM=amd
-DROCPROFSYS_BUILD_ELFUTILS=ON
-DROCPROFSYS_BUILD_TBB=ON
-DROCPROFSYS_BUILD_LIBIBERTY=ON
-DROCPROFSYS_BUILD_BOOST=ON
-DROCPROFSYS_BUILD_DYNINST=ON
Expand Down Expand Up @@ -327,6 +326,7 @@ if(THEROCK_ENABLE_ROCPROFV3)
rocprofiler-sdk
${THEROCK_BUNDLED_LIBDRM}
${THEROCK_BUNDLED_SQLITE3}
${THEROCK_BUNDLED_TBB}
${_openmpi_optional_dep}
)
therock_cmake_subproject_glob_c_sources(rocprofiler-systems
Expand Down
2 changes: 2 additions & 0 deletions third-party/sysdeps/linux/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ add_subdirectory(elfutils)
add_subdirectory("${CMAKE_CURRENT_SOURCE_DIR}/../common/mpfr" "${CMAKE_CURRENT_BINARY_DIR}/mpfr")
# libpciaccess for PCI device access.
add_subdirectory(libpciaccess)
add_subdirectory(tbb)
# hwloc depends on numactl and libpciaccess.
add_subdirectory("${CMAKE_CURRENT_SOURCE_DIR}/../common/hwloc" "${CMAKE_CURRENT_BINARY_DIR}/hwloc")

Expand All @@ -48,6 +49,7 @@ therock_provide_artifact(sysdeps
therock-libnl
therock-numactl
therock-sqlite3
therock-tbb
therock-zlib
therock-zstd
)
Expand Down
4 changes: 4 additions & 0 deletions third-party/sysdeps/linux/artifact.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ include = [
[components.lib."third-party/sysdeps/linux/sqlite3/build/stage"]
[components.dev."third-party/sysdeps/linux/sqlite3/build/stage"]

# tbb
[components.lib."third-party/sysdeps/linux/tbb/build/stage"]
[components.dev."third-party/sysdeps/linux/tbb/build/stage"]

# zlib
[components.lib."third-party/sysdeps/linux/zlib/build/stage"]
[components.dev."third-party/sysdeps/linux/zlib/build/stage"]
Expand Down
23 changes: 23 additions & 0 deletions third-party/sysdeps/linux/tbb/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Copyright Advanced Micro Devices, Inc.
# SPDX-License-Identifier: MIT

therock_subproject_fetch(therock-tbb-sources
CMAKE_PROJECT
# Originally mirrored from: https://github.com/uxlfoundation/oneTBB/archive/refs/tags/v2022.3.0.tar.gz
URL https://rocm-third-party-deps.s3.us-east-2.amazonaws.com/oneTBB-2022.3.0.tar.gz
URL_HASH SHA256=01598a46c1162c27253a0de0236f520fd8ee8166e9ebb84a4243574f88e6e50a
)

therock_cmake_subproject_declare(therock-tbb
USE_DIST_AMDGPU_TARGETS
BACKGROUND_BUILD
EXCLUDE_FROM_ALL
NO_MERGE_COMPILE_COMMANDS
OUTPUT_ON_FAILURE
EXTERNAL_SOURCE_DIR "${CMAKE_CURRENT_BINARY_DIR}/source"
CMAKE_ARGS
-DTBB_TEST=OFF
)

therock_cmake_subproject_provide_package(therock-tbb TBB lib/cmake)
therock_cmake_subproject_activate(therock-tbb)
Loading