Open
Conversation
marbre
reviewed
Apr 8, 2026
Member
marbre
left a comment
marbre
left a comment
There was a problem hiding this comment.
Some early feedback even though this is still a draft. Bundled sysdep might not be the right place. Is this linked statically or dynamically to rocprofiler?
Contributor
|
Please update the description's "motivation" and "technical details". Refer to #4399 for guidance. |
dgaliffiAMD
reviewed
Apr 9, 2026
dgaliffiAMD
added
the
test:rocprofiler-systems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adding TBB to third-party/sysdeps.
Technical Details
-D ROCPROFSYS_BUILD_TBB) and use the libraries built by TheRock.Test Plan
Test Result
Built successful, tests pass.
Submission Checklist