set subject name in I2PControl certificate - #2487
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The certificate i2pd makes for I2PControl has an empty subject: the name is
built and then set as the issuer only. OpenSSL 3 does not take it for self
signed, tries to build a chain and refuses the sha1 signature of that "CA":
so the service never starts at all. A plain self signed sha1 certificate made
by openssl loads on the same machine without a word, so the signature algorithm
is not the cause and is left alone here.
With the subject set the certificate loads and requests are answered, sha1 kept.
A certificate saved by an older version is replaced on start by the code that is
already there. Checked on Debian 13, OpenSSL 3.5.6.