sign I2PControl certificate with sha256 - #2484
Closed
pobregat0 wants to merge 1 commit into
Closed
Conversation
Contributor
袗 褝褌芯, 芯薪芯 胁 java sha1? 袗 芯薪芯 谢芯泻邪谢褜薪芯械 |
| X509_NAME_add_entry_by_txt (name, "CN", MBSTRING_ASC, (unsigned char *)I2P_CONTROL_CERTIFICATE_COMMON_NAME, -1, -1, 0); // common name | ||
| X509_set_issuer_name (x509, name); // set issuer to ourselves | ||
| X509_sign (x509, pkey, EVP_sha1 ()); // sign, last param must be NULL for EdDSA | ||
| X509_sign (x509, pkey, EVP_sha256 ()); // sha1 is rejected as too weak since OpenSSL 3 |
Contributor
|
泻泻 |
Contributor
|
It might be an issue with apps like itoopie |
Contributor
Author
|
Wrong fix: the digest is not the cause. The certificate has an empty subject, so OpenSSL 3 does not take it for self signed and refuses it as a weak CA. A self signed sha1 certificate loads fine on the same machine. Replaced by #2487, which sets the subject and leaves sha1 alone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On OpenSSL 3 the self signed certificate is signed with sha1, which is refused
at the default security level, so I2PControl never gets a working SSL context:
With sha256 the service starts and answers requests. Checked on Debian 13,
OpenSSL 3.5.6, and on a second machine with the same version.