Reschedule 'use VERSION' switch fatalisation to 5.46#24289
Merged
leonerd merged 1 commit intoPerl:bleadfrom Mar 23, 2026
Merged
Reschedule 'use VERSION' switch fatalisation to 5.46#24289leonerd merged 1 commit intoPerl:bleadfrom
leonerd merged 1 commit intoPerl:bleadfrom
Conversation
2083c99 to
46c53f6
Compare
Contributor
Author
|
While this is technically a code change, in practice it's just changing the future version number in a warning message and the documentation, so I think it's still fine to go in after the 5.43.9 release. Can we merge this in time to get it into 5.44? Otherwise we'll be releasing 5.44 with a message saying that something will be removed in 5.44 when it clearly hasn't been. |
We did say we'd do this for 5.44 but we forgot to make the change until now, and it's a bit late in the cycle. We'll reschedule it for 5.46.
46c53f6 to
c4ecda1
Compare
tonycoz
approved these changes
Mar 23, 2026
Contributor
tonycoz
left a comment
There was a problem hiding this comment.
It looks like a reasonable minimal change to me for what will be an actual bug once the version ticks over.
I don't see any reason to delay it, assuming the other PSC members agree (and I don't see why they'd disagree.)
Contributor
Author
Contributor
|
@ap suggested the change and @Leont gave it a thumbs up (which I hadn't noticed when I approved this.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We did say we'd do this for 5.44 but we forgot to make the change until now, and it's a bit late in the cycle. We'll reschedule it for 5.46.