Skip to content

Fatalise swapping a 'use VERSION' declaration, as previously promised#24288

Open
leonerd wants to merge 1 commit intoPerl:bleadfrom
leonerd:fatalise-use-version-swap
Open

Fatalise swapping a 'use VERSION' declaration, as previously promised#24288
leonerd wants to merge 1 commit intoPerl:bleadfrom
leonerd:fatalise-use-version-swap

Conversation

@leonerd
Copy link
Copy Markdown
Contributor

@leonerd leonerd commented Mar 16, 2026

Around 5.40 we said this would become fatal in 5.44. Since we're nearing 5.44 completion we should actually make good on this.

  • This set of changes requires a perldelta entry, and I need help writing it - I don't know where in the file it should be added

@leonerd leonerd force-pushed the fatalise-use-version-swap branch from 3e7ccb6 to 55f2b62 Compare March 16, 2026 16:07
@ap
Copy link
Copy Markdown
Contributor

ap commented Mar 16, 2026

It’s too late to do this in 5.44. For now we need a PR to change the warning to say 5.46 and then we need to revisit this as soon as the next dev cycle starts.

@leonerd leonerd added the defer-next-dev This PR should not be merged yet, but await the next development cycle label Mar 16, 2026
@jkeenan
Copy link
Copy Markdown
Contributor

jkeenan commented Mar 16, 2026

Around 5.40 we said this would become fatal in 5.44. Since we're nearing 5.44 completion we should actually make good on this.

* This set of changes requires a perldelta entry, and I need help writing it - I don't know where in the file it should be added

This was originally discussed in #23624, filed last August. As I reported there, I created a branch in which I encountered many test failures, including some which your p.r. is encountering. I was able to fix some but not all of those failures, so I never promoted my branch into a pull request. AFAICT no one else picked up that branch. As I indicated in #23624 (comment) three days ago, "Promotion of a deprecation warning into a fatalization almost always entails CPANtesters failures, which meets the minimum criterion for a "controversial change." Since we're past the "controversial changes" release deadline, this work will have to be deferred" to the next dev cycle. But in the meantime I encourage you to pick up the branch I was previously working on.

@leonerd
Copy link
Copy Markdown
Contributor Author

leonerd commented Mar 16, 2026

I've opened #24289 to just change the scheduled version number.

Comment thread t/lib/croak/op
Copy link
Copy Markdown
Contributor

@tonycoz tonycoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine, obviously deferred.

@leonerd leonerd force-pushed the fatalise-use-version-swap branch from eeafdb2 to cd40c03 Compare March 23, 2026 22:52
@leonerd leonerd force-pushed the fatalise-use-version-swap branch from cd40c03 to d58566d Compare March 23, 2026 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

defer-next-dev This PR should not be merged yet, but await the next development cycle

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants