Fatalise swapping a 'use VERSION' declaration, as previously promised#24288
Fatalise swapping a 'use VERSION' declaration, as previously promised#24288leonerd wants to merge 1 commit intoPerl:bleadfrom
Conversation
3e7ccb6 to
55f2b62
Compare
|
It’s too late to do this in 5.44. For now we need a PR to change the warning to say 5.46 and then we need to revisit this as soon as the next dev cycle starts. |
This was originally discussed in #23624, filed last August. As I reported there, I created a branch in which I encountered many test failures, including some which your p.r. is encountering. I was able to fix some but not all of those failures, so I never promoted my branch into a pull request. AFAICT no one else picked up that branch. As I indicated in #23624 (comment) three days ago, "Promotion of a deprecation warning into a fatalization almost always entails CPANtesters failures, which meets the minimum criterion for a "controversial change." Since we're past the "controversial changes" release deadline, this work will have to be deferred" to the next dev cycle. But in the meantime I encourage you to pick up the branch I was previously working on. |
|
I've opened #24289 to just change the scheduled version number. |
55f2b62 to
eeafdb2
Compare
eeafdb2 to
cd40c03
Compare
cd40c03 to
d58566d
Compare
Around 5.40 we said this would become fatal in 5.44. Since we're nearing 5.44 completion we should actually make good on this.