fix: disable scan for unsupported transactions#186
Draft
mikesposito wants to merge 5 commits intomainfrom
Draft
Conversation
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
mikesposito
commented
Feb 3, 2026
Comment on lines
186
to
188
| accountAddress: account.address, | ||
| parameters: { | ||
| from: context.scanParameters?.from ?? undefined, | ||
| to: context.scanParameters?.to ?? undefined, | ||
| data: context.scanParameters?.data ?? undefined, | ||
| value: context.scanParameters?.value ?? undefined, | ||
| }, | ||
| transactionRawData: rawData, | ||
| origin, |
Member
Author
There was a problem hiding this comment.
I felt like the expected shape of the scan parameters is a Blockaid detail, and should be handled internally by the SecurityAlertsApiClient, rather than api consumers around the snap codebase.
SecurityAlertsApiClient and TransactionScanService now accept a transactionRawData parameter instead of parameters for scan request.
7 tasks
Contributor
|
Note to continue: we just pass the data in, the client does what it needs to do regarding, checking if the simulation is supported, transforming the fields to correctly call it, throwing an error if unsupported |
Enhance security scan accuracy by limiting API calls to supported contract types and adjusting confirmation button behavior based on simulation accuracy. The previous implementation attempted to scan all transaction types, which could lead to misleading or irrelevant security alerts for unsupported contracts. This PR introduces a `simulationAccurate` flag to distinguish between reliable scans (for supported contracts) and unreliable ones (for unsupported contracts or multiple contract calls). For unreliable simulations, the "Estimated Changes" will be empty, and the user will always be able to proceed, even if the scan itself returns an error. For accurate simulations, the "Confirm" button will be blocked if the scan encounters an error, ensuring users are only blocked when the simulation is considered reliable. --- <p><a href="https://cursor.com/background-agent?bcId=bc-3af945ef-4817-4045-9ea9-6281fed76d50"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-3af945ef-4817-4045-9ea9-6281fed76d50"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p> Co-authored-by: Cursor Agent <[email protected]>
![https://cursor.com/assets/images/open-in-cursor-dark.png"><source](https://cursor.com/assets/images/open-in-cursor-dark.png"><source){kind=link}
![https://cursor.com/assets/images/open-in-cursor-light.png"><img](https://cursor.com/assets/images/open-in-cursor-light.png"><img){kind=link}
![https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a](https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a){kind=link}
![https://cursor.com/assets/images/open-in-web-dark.png"><source](https://cursor.com/assets/images/open-in-web-dark.png"><source){kind=link}
![https://cursor.com/assets/images/open-in-web-light.png"><img](https://cursor.com/assets/images/open-in-web-light.png"><img){kind=link}
![https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p](https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p){kind=link}
ulissesferreira
force-pushed
the
mikesposito/fix/disable-scan-for-unsupported-txs
branch
from
6f768c3 to
e759dc0
Compare
ulissesferreira
force-pushed
the
mikesposito/fix/disable-scan-for-unsupported-txs
branch
from
c8f46c4 to
785b3bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The transaction simulation is being disabled for unsupported transactions to prevent unreliable estimates and potential errors during processing, that may confuse users.
Fixes https://consensyssoftware.atlassian.net/browse/NEB-386