fix: disble Tron simulations for unsupported transactions by mikesposito · Pull Request #39736 · MetaMask/metamask-extension

mikesposito · 2026-02-03T14:14:31Z

Depends on:

fix: disable scan for unsupported transactions snap-tron-wallet#186

Description

This PR brings a fix for Tron simulations that were returning unreliable estimates because of an underlying Blockaid incompatibility with certain Tron transactions. As a temporary mitigation, this PR disables simulations for unsupported Tron transactions.

### Fixed

- Disable simulation for unsupported transactions ([#186](https://github.com/MetaMask/snap-tron-wallet/pull/186))
  - Supported transactions are those single-contract interaction transactions of the following types: `TransferContract`, `TriggerSmartContract`, `TransferAssetContract`.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

socket-security · 2026-02-03T14:16:28Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@metamask/tron-wallet-snap@1.19.2 ⏵ 1.20.0-preview-2895dbc	⁺¹		⁺⁵	⁺³

View full report

metamaskbotv2 · 2026-02-03T14:47:19Z

Builds ready [5577776]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

UI Startup Metrics (1509 ± 105 ms)

Platform	BuildType	Page	Metric	Test Title (ms)	Persona (ms)	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	1509	1254	1953	105	1570	1687
			load	-	-	1289	1054	1641	103	1351	1458
			domContentLoaded	-	-	1283	1046	1625	102	1344	1449
			domInteractive	-	-	30	19	127	21	26	93
			firstPaint	-	-	172	69	1467	145	217	257
			backgroundConnect	-	-	256	232	308	14	262	284
			firstReactRender	-	-	20	12	43	6	22	36
			initialActions	-	-	1	0	9	1	1	4
			loadScripts	-	-	1043	811	1355	101	1103	1205
			setupStore	-	-	15	6	182	17	17	24
			numNetworkReqs	-	-	22	15	83	17	15	73
			19	-	-	-	-	-	-	-	-
	Browserify	Power User Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	2070	1680	2782	195	2191	2396
			load	-	-	1198	1052	2015	168	1195	1673
			domContentLoaded	-	-	1184	1039	2006	169	1185	1666
			domInteractive	-	-	37	18	162	26	38	102
			firstPaint	-	-	180	70	553	97	250	350
			backgroundConnect	-	-	336	288	468	37	355	418
			firstReactRender	-	-	27	17	64	11	29	55
			initialActions	-	-	1	0	6	1	1	2
			loadScripts	-	-	933	810	1729	157	932	1366
			setupStore	-	-	18	8	77	11	20	45
			numNetworkReqs	-	-	122	49	264	53	145	246
			19	-	-	-	-	-	-	-	-
	Webpack	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
2			-	-	-	-	-	-	-	-
3			-	-	-	-	-	-	-	-
4			-	-	-	-	-	-	-	-
5			-	-	-	-	-	-	-	-
6			-	-	-	-	-	-	-	-
7			-	-	-	-	-	-	-	-
8			-	-	-	-	-	-	-	-
9			-	-	-	-	-	-	-	-
10			-	-	-	-	-	-	-	-
11			-	-	-	-	-	-	-	-
12			-	-	-	-	-	-	-	-
13			-	-	-	-	-	-	-	-
14			-	-	-	-	-	-	-	-
15			-	-	-	-	-	-	-	-
16			-	-	-	-	-	-	-	-
17			-	-	-	-	-	-	-	-
18			-	-	-	-	-	-	-	-
uiStartup			-	-	837	661	1148	107	901	1051
load			-	-	692	591	1058	98	747	895
domContentLoaded			-	-	687	587	1048	97	743	891
domInteractive			-	-	24	15	79	16	22	71
firstPaint			-	-	98	60	358	47	117	187
backgroundConnect			-	-	37	18	122	22	44	79
firstReactRender			-	-	15	10	121	12	15	30
initialActions			-	-	1	0	5	1	1	2
loadScripts			-	-	684	585	1046	97	742	889
setupStore			-	-	11	6	27	4	11	22
numNetworkReqs			-	-	22	15	88	18	15	77
19			-	-	-	-	-	-	-	-
Webpack	Power User Home	0	-	-	-	-	-	-	-	-
		1	-	-	-	-	-	-	-	-
		2	-	-	-	-	-	-	-	-
		3	-	-	-	-	-	-	-	-
		4	-	-	-	-	-	-	-	-
		5	-	-	-	-	-	-	-	-
		6	-	-	-	-	-	-	-	-
		7	-	-	-	-	-	-	-	-
		8	-	-	-	-	-	-	-	-
		9	-	-	-	-	-	-	-	-
		10	-	-	-	-	-	-	-	-
		11	-	-	-	-	-	-	-	-
		12	-	-	-	-	-	-	-	-
		13	-	-	-	-	-	-	-	-
		14	-	-	-	-	-	-	-	-
		15	-	-	-	-	-	-	-	-
		16	-	-	-	-	-	-	-	-
		17	-	-	-	-	-	-	-	-
		18	-	-	-	-	-	-	-	-
		uiStartup	-	-	1238	874	1833	210	1395	1666
		load	-	-	710	619	1149	108	704	1017
		domContentLoaded	-	-	701	614	1142	108	689	1007
		domInteractive	-	-	37	18	255	33	35	116
		firstPaint	-	-	157	66	955	139	153	520
		backgroundConnect	-	-	169	133	414	63	163	366
		firstReactRender	-	-	23	18	35	3	24	30
		initialActions	-	-	1	0	2	1	1	1
		loadScripts	-	-	698	612	1132	106	687	999
		setupStore	-	-	11	5	19	3	13	17
		numNetworkReqs	-	-	125	50	264	55	156	250
		19	-	-	-	-	-	-	-	-
Firefox	Browserify	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	1620	1320	2028	164	1734	1919
			load	-	-	1360	1133	1747	129	1445	1584
			domContentLoaded	-	-	1359	1127	1747	129	1445	1578
			domInteractive	-	-	77	34	250	43	98	147
			firstPaint	-	-	-	-	-	-	-	-
			backgroundConnect	-	-	67	29	189	38	64	161
			firstReactRender	-	-	12	10	21	1	12	14
			initialActions	-	-	1	0	3	1	2	2
			loadScripts	-	-	1325	1109	1730	116	1409	1532
			setupStore	-	-	16	4	175	25	13	63
			numNetworkReqs	-	-	23	12	88	19	18	81
			19	-	-	-	-	-	-	-	-
	Browserify	Power User Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	3027	2223	4745	534	3177	4242
			load	-	-	1611	1304	2642	316	1769	2268
			domContentLoaded	-	-	1611	1303	2642	316	1769	2267
			domInteractive	-	-	119	36	528	96	116	356
			firstPaint	-	-	-	-	-	-	-	-
			backgroundConnect	-	-	318	113	1097	244	329	910
			firstReactRender	-	-	20	14	64	9	20	26
			initialActions	-	-	1	1	3	1	2	2
			loadScripts	-	-	1556	1282	2616	280	1664	2168
			setupStore	-	-	130	8	789	197	101	645
			numNetworkReqs	-	-	73	40	203	43	99	183
			19	-	-	-	-	-	-	-	-
	Webpack	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
2			-	-	-	-	-	-	-	-
3			-	-	-	-	-	-	-	-
4			-	-	-	-	-	-	-	-
5			-	-	-	-	-	-	-	-
6			-	-	-	-	-	-	-	-
7			-	-	-	-	-	-	-	-
8			-	-	-	-	-	-	-	-
9			-	-	-	-	-	-	-	-
10			-	-	-	-	-	-	-	-
11			-	-	-	-	-	-	-	-
12			-	-	-	-	-	-	-	-
13			-	-	-	-	-	-	-	-
14			-	-	-	-	-	-	-	-
15			-	-	-	-	-	-	-	-
16			-	-	-	-	-	-	-	-
17			-	-	-	-	-	-	-	-
18			-	-	-	-	-	-	-	-
uiStartup			-	-	1738	1444	2665	211	1864	2145
load			-	-	1491	1251	2455	164	1583	1717
domContentLoaded			-	-	1490	1251	2455	164	1583	1717
domInteractive			-	-	93	32	650	77	131	167
firstPaint			-	-	-	-	-	-	-	-
backgroundConnect			-	-	74	27	325	54	84	201
firstReactRender			-	-	16	11	57	5	16	21
initialActions			-	-	1	0	2	1	2	2
loadScripts			-	-	1454	1226	2423	152	1533	1655
setupStore			-	-	18	4	243	35	12	53
numNetworkReqs			-	-	23	12	85	19	18	81
19			-	-	-	-	-	-	-	-
Webpack	Power User Home	0	-	-	-	-	-	-	-	-
		1	-	-	-	-	-	-	-	-
		2	-	-	-	-	-	-	-	-
		3	-	-	-	-	-	-	-	-
		4	-	-	-	-	-	-	-	-
		5	-	-	-	-	-	-	-	-
		6	-	-	-	-	-	-	-	-
		7	-	-	-	-	-	-	-	-
		8	-	-	-	-	-	-	-	-
		9	-	-	-	-	-	-	-	-
		10	-	-	-	-	-	-	-	-
		11	-	-	-	-	-	-	-	-
		12	-	-	-	-	-	-	-	-
		13	-	-	-	-	-	-	-	-
		14	-	-	-	-	-	-	-	-
		15	-	-	-	-	-	-	-	-
		16	-	-	-	-	-	-	-	-
		17	-	-	-	-	-	-	-	-
		18	-	-	-	-	-	-	-	-
		uiStartup	-	-	3028	2060	7747	743	3343	4198
		load	-	-	1683	1231	6164	583	1830	2554
		domContentLoaded	-	-	1683	1231	6163	583	1829	2554
		domInteractive	-	-	114	33	641	118	106	522
		firstPaint	-	-	-	-	-	-	-	-
		backgroundConnect	-	-	343	113	1341	282	398	948
		firstReactRender	-	-	21	15	32	4	24	29
		initialActions	-	-	2	0	6	1	2	3
		loadScripts	-	-	1610	1213	6136	564	1706	2470
		setupStore	-	-	171	6	893	233	208	725
		numNetworkReqs	-	-	70	38	188	43	82	184
		19	-	-	-	-	-	-	-	-

📊 Page Load Benchmark Results

Current Commit: 5577776 | Date: 2/3/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.07s (±73ms) 🟡 | historical mean value: 1.02s ⬆️ (historical data)
domContentLoaded-> current mean value: 752ms (±70ms) 🟢 | historical mean value: 713ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±12ms) 🟢 | historical mean value: 79ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.07s	73ms	1.03s	1.36s	1.30s	1.36s
domContentLoaded	752ms	70ms	714ms	1.03s	966ms	1.03s
firstPaint	79ms	12ms	64ms	184ms	88ms	184ms
firstContentfulPaint	79ms	12ms	64ms	184ms	88ms	184ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 0 Bytes (0%)
common: 114 Bytes (0%)

fix: disble Tron simulations for unsupported transactions

5577776

mikesposito temporarily deployed to pr-comment February 3, 2026 14:14 — with GitHub Actions Inactive

mikesposito marked this pull request as draft February 3, 2026 14:14

metamaskbot added the team-core-platform Core Platform team label Feb 3, 2026

github-actions bot added the size-XS label Feb 3, 2026

mikesposito temporarily deployed to pr-comment February 3, 2026 14:42 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: disble Tron simulations for unsupported transactions#39736

fix: disble Tron simulations for unsupported transactions#39736
mikesposito wants to merge 1 commit intomainfrom
mikesposito/fix/disable-tron-scan-for-unsupported-tx

mikesposito commented Feb 3, 2026 •

edited

Loading

Uh oh!

socket-security bot commented Feb 3, 2026

Uh oh!

metamaskbotv2 bot commented Feb 3, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mikesposito commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

socket-security bot commented Feb 3, 2026

Uh oh!

metamaskbotv2 bot commented Feb 3, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mikesposito commented Feb 3, 2026 •

edited

Loading