Skip to content

Add missing Hint clarities back#6477

Open
jeromkiller wants to merge 4 commits intoHarbourMasters:develop-ackbarfrom
jeromkiller:HintClarityFix
Open

Add missing Hint clarities back#6477
jeromkiller wants to merge 4 commits intoHarbourMasters:develop-ackbarfrom
jeromkiller:HintClarityFix

Conversation

@jeromkiller
Copy link
Copy Markdown
Member

@jeromkiller jeromkiller commented Apr 9, 2026

With all of the hint texts moved to separate files it looks like the Ambiguous and Obscure hints both got broken and always display as clear hints.

This change attempts to rectify this by getting the hint text for the item instead of the item name.

The article for the name doesn't always work with the ambiguous text (Iron boots -> "The some boots"). If hint clarity wasn't ported over because of this new system. free to kick this PR to the curb.

The different Obscure and Ambiguous names that can be picked for items also seem to always be the same, but I haven't looked at that too hard yet.

Build Artifacts

@jeromkiller jeromkiller requested a review from leggettc18 April 9, 2026 11:54
@serprex
Copy link
Copy Markdown
Member

serprex commented Apr 10, 2026

feels like for hints article would have to be associated to the hint name, rather than the item name

@Pepper0ni
Copy link
Copy Markdown
Contributor

Pepper0ni commented Apr 10, 2026

I had a draft refactor in PR #5238 that would be a place to handle this, but it was waiting for all the item shuffles (notably roll) to get in to avoid mass conflicts and then needs a lot of catching up

@Pepper0ni
Copy link
Copy Markdown
Contributor

Going back to this with a focus on short term solutions, I think it's fine for not to just exclude articles for non-clear hints, and it can be cleaned up properly when I finally get around to updating #5238

@serprex
Copy link
Copy Markdown
Member

serprex commented Apr 12, 2026

jeromkiller#18 opened PR against this to only apply articles to clear hints

…essage, avoids generating \x02 after item name hint (#18)
@jeromkiller
Copy link
Copy Markdown
Member Author

I'm fine with this getting undone down the line in favor of something more robust, having this as a temp solution allows me to get on with implementing hint clarity for archi

@serprex serprex requested a review from Pepper0ni April 12, 2026 14:34
@Pepper0ni Pepper0ni mentioned this pull request Apr 12, 2026
@Pepper0ni
Copy link
Copy Markdown
Contributor

I found an issue where clear hints have a repeating a sometimes (displaying as "a a piece of heart")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants