Add missing Hint clarities back#6477
Add missing Hint clarities back#6477jeromkiller wants to merge 4 commits intoHarbourMasters:develop-ackbarfrom
Conversation
|
feels like for hints article would have to be associated to the hint name, rather than the item name |
|
I had a draft refactor in PR #5238 that would be a place to handle this, but it was waiting for all the item shuffles (notably roll) to get in to avoid mass conflicts and then needs a lot of catching up |
|
Going back to this with a focus on short term solutions, I think it's fine for not to just exclude articles for non-clear hints, and it can be cleaned up properly when I finally get around to updating #5238 |
|
jeromkiller#18 opened PR against this to only apply articles to clear hints |
…essage, avoids generating \x02 after item name hint (#18)
|
I'm fine with this getting undone down the line in favor of something more robust, having this as a temp solution allows me to get on with implementing hint clarity for archi |
|
I found an issue where clear hints have a repeating a sometimes (displaying as "a a piece of heart") |
With all of the hint texts moved to separate files it looks like the Ambiguous and Obscure hints both got broken and always display as clear hints.
This change attempts to rectify this by getting the hint text for the item instead of the item name.
The article for the name doesn't always work with the ambiguous text (Iron boots -> "The some boots"). If hint clarity wasn't ported over because of this new system. free to kick this PR to the curb.
The different Obscure and Ambiguous names that can be picked for items also seem to always be the same, but I haven't looked at that too hard yet.
Build Artifacts