Shuffle Silver by serprex · Pull Request #5659 · HarbourMasters/Shipwright

serprex · 2025-07-08T01:43:16Z

implement Silver Rupee Shuffle so that I start caring about it when @Pepper0ni is always bringing it up in logic refactors

Build Artifacts

serprex · 2025-07-13T00:24:40Z

currently blocked on logic refactors: #5649 #5456 #5650 #5661 #5662 #5664

serprex · 2026-03-29T22:32:52Z

pulled tracker support from leggetc13's version. made a few fixes to tracker while in there (deal with RG/ITEM/QUEST overlaps, don't create textures for jabbernuts)

Would like to get kaleido in, but otherwise think this is ready to go in. Just needs testing. Maybe bringing over debug editor stuff would help there too

chartergirl64 · 2026-04-01T05:33:22Z

Did my first playtest and found :

Silver rupee shuffle needs a tooltip explaining the options.
Greg on the item tracker has a 0/5 on start - seems to be pulling count from Training Ground Silver: Slope.
The silver rupees are invisible both as freestanding and as get item animation.
The silver rupee checks on check tracker are_formatted_like_this.

Some strange visuals (see image). The X marks where a silver rupee is and the spiky things show up when there is one on screen, sometimes.

serprex · 2026-04-02T03:01:34Z

not sure how that broke in rebase, but ported over draw code from leggettc's branch

Xandervile · 2026-04-02T17:38:28Z

Noticed I had issues with generating seeds with silver rupee shuffle on, unsure if this conflicts with some other settings

Settings List I Had:

No Logic
Mixed Dungeons + Bosses Pool
Keysanity, random KeyRings

chartergirl64 · 2026-04-03T09:56:10Z

They aren't invisible anymore but they are quite large compared to everything else. (pics below)

Getting a stick bag marks your fishing pole as received on the item tracker. This is true whether added on debug or found organically.

Silver Rupee wallets (or start with) mark as 10/5 on item tracker when collected.

There's definitely something going on where several single silver rupees are not tracking on item tracker when collected but I do not have enough data yet on what all isn't tracking/why. Sometimes Shadow Silver: Spikes, Training Ground Silver: Water, and Training Ground Silver: Slope do not mark on tracker when collected but not always. There could be others, will test more.

Was not able to reproduce issue Xanderville had with generating seed on this build but did have generation issues on nightly although unsure of exact settings unfortunately.

Pepper0ni

Did a quick sweep of the logic to point out obvious issues.

Pepper0ni · 2026-04-01T21:34:09Z

soh/soh/Enhancements/randomizer/location_access/dungeons/bottom_of_the_well.cpp

        LOCATION(RC_BOTTOM_OF_THE_WELL_BASEMENT_GRASS_2,   logic->CanCutShrubs()),
        LOCATION(RC_BOTTOM_OF_THE_WELL_BASEMENT_GRASS_3,   logic->CanCutShrubs()),
+        LOCATION(RC_BOTW_SILVER_1,                         true /*CanClimbHigh()*/),
+        LOCATION(RC_BOTW_SILVER_2,                         true /*CanClimb()*/),


Doorsanity will want to split this region up.

Pepper0ni · 2026-04-01T22:03:11Z

soh/soh/Enhancements/randomizer/location_access/dungeons/ganons_castle.cpp

@@ -72,8 +72,16 @@ void RegionTable_Init_GanonsCastle() {
    });

    areaTable[RR_GANONS_CASTLE_FOREST_TRIAL_BEAMOS_ROOM] = Region("Ganon's Castle Forest Trial Beamos Room", SCENE_INSIDE_GANONS_CASTLE, {


We probably want to Rename END into MIDDLE.

The event and first silver can only be reached from the front, and are true as you get it while doing the fan jump.

3 and 4 are simple from the middle, 5 is simple from the end.

2 needs to be in middle (is adult or hookshot), and front (true) due to child not being able to climb the target.

Pepper0ni · 2026-04-01T22:05:14Z

soh/soh/Enhancements/randomizer/location_access/dungeons/ganons_castle.cpp

+        LOCATION(RC_GANONS_CASTLE_SILVER_FIRE_2,    logic->FireTimer() >= 24),
+        LOCATION(RC_GANONS_CASTLE_SILVER_FIRE_3,    logic->FireTimer() >= 40 && logic->CanUse(RG_GOLDEN_GAUNTLETS)),
+        LOCATION(RC_GANONS_CASTLE_SILVER_FIRE_4,    logic->FireTimer() >= 8),
+        LOCATION(RC_GANONS_CASTLE_SILVER_FIRE_5,    logic->FireTimer() >= 32 && logic->CanUse(RG_GOLDEN_GAUNTLETS)),


looks like a refactor happened and now this needs changing

Pepper0ni · 2026-04-01T22:13:58Z

soh/soh/Enhancements/randomizer/location_access/dungeons/ganons_castle.cpp

+    }, {
+        //Locations
+        //TODO figure it out
+        LOCATION(RC_GANONS_CASTLE_MQ_SILVER_WATER_1, true),


The Middair ground jump needs adding, plus the power bracelet logic.

Child can get the middair silver doing a rolljump from the peg to grab the block.

Pepper0ni · 2026-04-01T22:29:38Z

soh/soh/Enhancements/randomizer/location_access/dungeons/ganons_castle.cpp

    }, {
        //Exits
        ENTRANCE(RR_GANONS_CASTLE_MQ_SHADOW_TRIAL_BEAMOS_TORCH, logic->CanUse(RG_FIRE_ARROWS) || logic->CanUse(RG_HOVER_BOOTS)),
        //Modelling the silver rupees properly will require a way to check temp flags in different regions.


OK, I had a think, and we can probably skip the assumption by setting the event on Moving Platform and baking in all the other requirements from there, which sucks but at least avoids the need for temp flag storage nonsense.

Pepper0ni · 2026-04-03T13:21:29Z

soh/soh/Enhancements/randomizer/location_access/dungeons/shadow_temple.cpp

+        LOCATION(RC_SHADOW_MQ_SILVER_SPIKES_3,  true),
+        LOCATION(RC_SHADOW_MQ_SILVER_SPIKES_4,  (ctx->GetTrickOption(RT_LENS_SHADOW_MQ) || logic->CanUse(RG_LENS_OF_TRUTH)) && logic->CanUse(RG_HOOKSHOT)),
+        LOCATION(RC_SHADOW_MQ_SILVER_SPIKES_6,  logic->CanUse(RG_HOOKSHOT)),
+        LOCATION(RC_SHADOW_MQ_SILVER_SPIKES_9,  true),


The platform with 1 doesn't seem to be reachable with hovers without a backwalk/backflip or rolling, and should probably be split off. Also probably wants a lens check as it's invisible.

9 needs a jumpslash or hovers to reach, even a rolljump isn't enough.

Pepper0ni · 2026-04-03T14:03:15Z

soh/soh/Enhancements/randomizer/location_access/dungeons/shadow_temple.cpp

+    areaTable[RR_SHADOW_TEMPLE_INVISIBLE_SPIKES_PLATFORM] = Region("Shadow Temple Invisible Spikes Platform", SCENE_SHADOW_TEMPLE, {}, {
+        //Locations
+        // can also get 2 & 4 with hovers backwalk backflip
+        LOCATION(RC_SHADOW_SILVER_SPIKES_1, logic->CanUse(RG_HOVER_BOOTS)),


Comment that it needs rolls or backwalk backflip, probably wants lens.

I would probably make the platform it's own region at this point.

Pepper0ni · 2026-04-03T14:19:32Z

soh/soh/Enhancements/randomizer/location_access/dungeons/spirit_temple.cpp

        //to get enough distance to reach the rupee
-        EVENT_ACCESS(LOGIC_SPIRIT_BOUNDERS_SILVERS, logic->CanUse(RG_HOVER_BOOTS) || logic->CanJumpslash() || logic->CanUse(RG_LONGSHOT)/* || CanBunnyHop()*/),
-    }, {}, {
+        EVENT_ACCESS(LOGIC_SPIRIT_SILVER_BOULDERS, logic->CanUse(RG_HOVER_BOOTS) || logic->CanJumpslash() || logic->CanUse(RG_LONGSHOT)/* || CanBunnyHop()*/),


Child needs roll to get the jumpslash here, and it's still pretty precise and may be trickworthy. Also, there's a damage boost off the boulder to grab it.

Pepper0ni · 2026-04-03T14:28:44Z

soh/soh/Enhancements/randomizer/location_access/dungeons/spirit_temple.cpp

        LOCATION(RC_SPIRIT_TEMPLE_MQ_ENTRANCE_POT_3,             logic->CanBreakPots()),
        LOCATION(RC_SPIRIT_TEMPLE_MQ_ENTRANCE_POT_4,             logic->CanBreakPots()),
+        LOCATION(RC_SPIRIT_MQ_SILVER_LOBBY_1,                    true),
+        LOCATION(RC_SPIRIT_MQ_SILVER_LOBBY_2,                    true),


2 and 3 are under boulders, 1 and 4 are in RR_SPIRIT_TEMPLE_MQ_BEHIND_GEYSER, and 5 is in the geyser which realistically needs to be in RR_SPIRIT_TEMPLE_MQ_BEHIND_GEYSER as that's whrere the switch is.

Pepper0ni · 2026-04-03T14:31:45Z

soh/soh/Enhancements/randomizer/location_access/dungeons/spirit_temple.cpp

        EVENT_ACCESS(LOGIC_SPIRIT_MQ_BIG_WALL_SILVERS, (logic->CanKillEnemy(RE_KEESE) || logic->CanUse(RG_SKULL_MASK)) && (logic->HasItem(RG_CLIMB) || logic->CanUse(RG_LONGSHOT))),
-    }, {}, {
+    }, {
+        LOCATION(RC_SPIRIT_MQ_SILVER_BIG_WALL_1, logic->Get(LOGIC_SPIRIT_MQ_SILVER_BIG_WALL) || logic->TakeDamage()),


This sections needs whole new logic because this statement was built on the fact you can't drop down and collect all 5 climbless from the top, while the climb up logic was built assuming you went all the way up and doesn't apply to lower rupees in vaccum.

The funny Keese logic here (instead of CanAvoid(RE_KEESE)) is because the wall as a whole is too high for stunning to hold them up long enough, for the lower rupees this isn't needed. Hookshot is also enough to reach some of them climbless.

Also, most of these can be placed both here (dropdown strategies) or at BASE.

Xandervile · 2026-04-04T15:18:17Z

Figured out my specific issue - the silver rupees shuffle seem to fail when Master Quest Dungeons are turned on. Tried random, sometimes works, sometimes doesn't, No MQ gens fine, all MQ seems to always fail. This is true in No Logic as well, something weird.

Xandervile · 2026-04-12T14:46:14Z

Did more digging - it doesn't generate when Ganon's Castle is MQ version. Think there is something iffy with that in particular. All other dungeons work when MQ.

Pepper0ni · 2026-04-12T14:48:42Z

it's probably #6487 ,it should get merged into develop soon after the release

serprex force-pushed the shuffle-silver branch from acd133f to fb7e9ea Compare July 9, 2025 02:36

serprex marked this pull request as draft July 9, 2025 04:02

serprex mentioned this pull request Oct 2, 2025

Shuffle silver rupees #5826

Closed

serprex force-pushed the shuffle-silver branch 5 times, most recently from dfd4739 to e03ded9 Compare November 24, 2025 13:23

serprex mentioned this pull request Nov 24, 2025

Add missing extension trick to Shadow MQ, bombing spirit trial switch, & add non-combat giant knife logic #5983

Merged

serprex force-pushed the shuffle-silver branch 2 times, most recently from 4b13e03 to b5db8b5 Compare December 12, 2025 05:47

serprex force-pushed the shuffle-silver branch 4 times, most recently from 5573ba6 to 425bab1 Compare January 6, 2026 04:10

serprex requested a review from Pepper0ni January 13, 2026 02:59

serprex force-pushed the shuffle-silver branch from 425bab1 to 245ca61 Compare January 17, 2026 05:50

serprex force-pushed the shuffle-silver branch 3 times, most recently from 3ee9270 to 91a1fcd Compare March 29, 2026 22:25

serprex marked this pull request as ready for review March 29, 2026 22:31

serprex and others added 4 commits April 1, 2026 01:05

shuffle silver

03b489f

port improvements from leggettc's version

ab85292

fix big wall, fix toilet

f9db097

fixes

4cca9d9

serprex force-pushed the shuffle-silver branch from 91a1fcd to 5a51e56 Compare April 1, 2026 01:17

serprex added 2 commits April 1, 2026 01:19

tracker

5a51e56

SCENE_WATER_TEMPLE

f8b0dd5

fix rendering

ab790a3

serprex force-pushed the shuffle-silver branch from e629f69 to ef25bd1 Compare April 2, 2026 12:51

serprex added 2 commits April 2, 2026 12:54

fix tracker putting number on greg by being more strict about item.kind

ef25bd1

tooltip

543523d

Pepper0ni suggested changes Apr 3, 2026

View reviewed changes

		@@ -72,8 +72,16 @@ void RegionTable_Init_GanonsCastle() {
		});

		areaTable[RR_GANONS_CASTLE_FOREST_TRIAL_BEAMOS_ROOM] = Region("Ganon's Castle Forest Trial Beamos Room", SCENE_INSIDE_GANONS_CASTLE, {

Conversation

serprex commented Jul 8, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Artifacts

Uh oh!

serprex commented Jul 13, 2025

Uh oh!

serprex commented Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chartergirl64 commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

serprex commented Apr 2, 2026

Uh oh!

Xandervile commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chartergirl64 commented Apr 3, 2026

Uh oh!

Pepper0ni left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Xandervile commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Xandervile commented Apr 12, 2026

Uh oh!

Pepper0ni commented Apr 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

serprex commented Jul 8, 2025 •

edited by github-actions bot

Loading

serprex commented Mar 29, 2026 •

edited

Loading

chartergirl64 commented Apr 1, 2026 •

edited

Loading

Xandervile commented Apr 2, 2026 •

edited

Loading

Xandervile commented Apr 4, 2026 •

edited

Loading

Pepper0ni commented Apr 12, 2026 •

edited

Loading