Skip to content

Update definition area samp size #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Woolly-at-EBI wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update definition area samp size #1079

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ddbf0d
Update mixs.yaml area_samp_size definition
Woolly-at-EBI Dec 5, 2025
f318bd9
Update mixs.yaml area_samp_size put example back
Woolly-at-EBI Dec 5, 2025
cd218eb
Merge main into update-definition-area_samp_size
turbomam Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/mixs/schema/mixs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4518,11 +4518,10 @@ slots:
annotations:
Expected_value: measurement value
Preferred_unit: centimeter
description: The total amount or size (volume (ml), mass (g) or area (m2) ) of
sample collected
description: The total area over which the sample was collected
title: area sampled size
examples:
- value: 12 centimeter x 12 centimeter
- value: 12 cm x 12 cm
Comment on lines +5289 to +5292

Copilot AI Mar 11, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated description reads like this slot expects a single area value, but the current serialization pattern and example still represent two linear dimensions ({integer} {unit} x {integer} {unit}) with Preferred_unit: centimeter. Consider either (a) revising the description to explicitly say it captures the dimensions/extent of the sampled area, or (b) switching the slot to accept an area measurement (e.g., square centimeter) and updating Preferred_unit, string_serialization, and the example accordingly so they’re consistent.

Copilot uses AI. Check for mistakes.
keywords:
- area
- sample
Expand Down
Loading