Conversation
Currently in v6.2 the definitions of area_samp_size and samp_size are both identical. The current definition is "The total amount or size (volume (ml), mass (g) or area (m2) ) of sample collected." The proposal here is for area_samp_size to have a cleaner more differentiated definition. (My preference would be that that this was explicitly an area so could be say 144 cm^2 rather than a dimension 12 cm x 12 cm. Could then cope with non-quadrangles etc., but that is for another time))
Woolly-at-EBI
added
the
1-TermUpdate
LinkML Linting ResultsSummary
|
|
|
Lets add an issue to link this PR to. |
There was a problem hiding this comment.
Pull request overview
This PR updates the MIxS schema to better differentiate area_samp_size from samp_size by refining the area_samp_size definition.
Changes:
- Updated
area_samp_sizedescription to focus specifically on the sampling area. - Updated the
area_samp_sizeexample value.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| description: The total area over which the sample was collected | ||
| title: area sampled size | ||
| examples: | ||
| - value: 12 centimeter x 12 centimeter | ||
| - value: 12 cm x 12 cm |
There was a problem hiding this comment.
The updated description reads like this slot expects a single area value, but the current serialization pattern and example still represent two linear dimensions ({integer} {unit} x {integer} {unit}) with Preferred_unit: centimeter. Consider either (a) revising the description to explicitly say it captures the dimensions/extent of the sampled area, or (b) switching the slot to accept an area measurement (e.g., square centimeter) and updating Preferred_unit, string_serialization, and the example accordingly so they’re consistent.
|
I requested Copilot reviews here because I’m helping triage/review MIxS PRs, not because I authored them. If you have the same GitHub permissions and Copilot access, you can do the same on any PR. You’ll know you’re enabled if you can see the Copilot review option in the PR review UI or related actions; if not, you likely need org/repo access and a Copilot seat or feature enablement from the repo or GitHub org admins. |
|
We've requested a GitHub Copilot review on this PR as part of a pass across all open MixS PRs. Copilot catches things like unused imports, resource leaks, and naming inconsistencies — it's a lightweight first pass, not a substitute for human review. No action needed from you unless Copilot flags something you agree with. |
Currently in v6.2 the definitions of area_samp_size and samp_size are both identical. The current definition is "The total amount or size (volume (ml), mass (g) or area (m2) ) of sample collected."
The proposal here is for area_samp_size to have a cleaner more differentiated definition.
(My preference would be that that this was explicitly an area so could be say 144 cm^2 rather than a dimension 12 cm x 12 cm. Could then cope with non-quadrangles etc., but that is for another time))