Skip to content

fix: use string defaults so schemas can include them, but validate them #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joanise merged 1 commit into from
Mar 24, 2026
Merged

fix: use string defaults so schemas can include them, but validate them #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions hfgl/config/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,7 @@
init_context,
)
from everyvoice.config.utils import PossiblySerializedCallable, load_partials
from everyvoice.utils import (
load_config_from_json_or_yaml_path,
original_hifigan_leaky_relu,
)
from everyvoice.utils import load_config_from_json_or_yaml_path
from pydantic import (
Field,
FilePath,
Expand Down Expand Up @@ -90,7 +87,8 @@ class HiFiGANModelConfig(ConfigModel):
description="The dilations of each convolution in each layer of the resblock.",
)
activation_function: PossiblySerializedCallable = Field(
default=original_hifigan_leaky_relu,
default="everyvoice.utils.original_hifigan_leaky_relu",
validate_default=True,
description="The activation function to use.",
)
istft_layer: bool = Field(
Expand Down
Loading