fix: use string defaults so schemas can include them, but validate them#59
Merged
fix: use string defaults so schemas can include them, but validate them#59
Conversation
When a pydantic field is a class, its default should still be a string so it can be included in the schemas, but we should request it be validated with `validate_default=True` so it gets converted correctly by the before validator.
|
Review changes with |
marctessier
approved these changes
Mar 23, 2026
Collaborator
marctessier
left a comment
marctessier
left a comment
There was a problem hiding this comment.
I did not see issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See EveryVoiceTTS/EveryVoice#781