Skip to content

Preparatory work for Hyperion supervisor: Hyperion planrunner refactor#1531

Merged
rtuck99 merged 9 commits intomainfrom
hyperion-planrunner-refactor
Jan 15, 2026
Merged

Preparatory work for Hyperion supervisor: Hyperion planrunner refactor#1531
rtuck99 merged 9 commits intomainfrom
hyperion-planrunner-refactor

Conversation

@rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Dec 18, 2025

Preparatory work for

Requires:

This updates the PlanRunner to make the move_to_udc_default_state and clean_up_udc plans something that is invoked using the same mechanism as the main load_centre_collect_full plan.

PlanRunner is further subclasses into an InProcessRunner in anticipation of implementing a sibling class which implements plan execution using a BlueAPI client to a remote server.

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@rtuck99 rtuck99 mentioned this pull request Dec 18, 2025
1 task
@rtuck99 rtuck99 changed the base branch from main to hyperion_on_blueapi December 18, 2025 15:42
@rtuck99 rtuck99 added the dev experience Changes relating to developer experience label Dec 18, 2025
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 98.54015% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.29%. Comparing base (58f0ca1) to head (5b392ce).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1531      +/-   ##
==========================================
+ Coverage   92.28%   92.29%   +0.01%     
==========================================
  Files         143      144       +1     
  Lines        8126     8167      +41     
==========================================
+ Hits         7499     7538      +39     
- Misses        627      629       +2     
Components Coverage Δ
i24 SSX 78.56% <ø> (ø)
hyperion 97.90% <98.51%> (-0.05%) ⬇️
other 98.00% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtuck99 rtuck99 marked this pull request as ready for review January 5, 2026 14:40
@rtuck99 rtuck99 requested a review from a team as a code owner January 5, 2026 14:40
@rtuck99 rtuck99 force-pushed the hyperion_on_blueapi branch from 211fb63 to 575614e Compare January 5, 2026 16:12
@rtuck99 rtuck99 force-pushed the hyperion-planrunner-refactor branch from 0769d9d to 0671ffd Compare January 5, 2026 16:17
Base automatically changed from hyperion_on_blueapi to main January 8, 2026 11:55
Copy link
Contributor

@jacob720 jacob720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@@ -32,6 +32,10 @@
PARAMETER_VERSION = Version.parse("5.3.0")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the version need bumping with these changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking, I guess since the changes are additions to the interface rather than changes to existing it would be a micro-version increment.

TBH I think the parameter versioning is not terribly important at the moment. We don't persist these parameter models anywhere and so far the only users are GDA, the as-yet non-existent hyperion-supervisor, and the external callbacks (via bluesky events). These all get corresponding changes whenever the parameter models are changed. So the chance of client and servers interacting with a different version of the parameter model is pretty minimal.

PARAMETER_VERSION doesn't appear to have changed for almost exactly a year, and I'm sure we've made other changes since then so I think it is kind of just stuck on 5.3.0 for the time being until there is a need to change it.

@rtuck99 rtuck99 force-pushed the hyperion-planrunner-refactor branch from 0671ffd to da524f4 Compare January 15, 2026 14:58
@rtuck99 rtuck99 enabled auto-merge (squash) January 15, 2026 15:04
@rtuck99 rtuck99 merged commit 6e45f38 into main Jan 15, 2026
6 of 8 checks passed
@rtuck99 rtuck99 deleted the hyperion-planrunner-refactor branch January 15, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev experience Changes relating to developer experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants