Preparatory work for Hyperion supervisor: Hyperion planrunner refactor#1531
Preparatory work for Hyperion supervisor: Hyperion planrunner refactor#1531
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1531 +/- ##
==========================================
+ Coverage 92.28% 92.29% +0.01%
==========================================
Files 143 144 +1
Lines 8126 8167 +41
==========================================
+ Hits 7499 7538 +39
- Misses 627 629 +2
🚀 New features to boost your workflow:
|
211fb63 to
575614e
Compare
0769d9d to
0671ffd
Compare
| @@ -32,6 +32,10 @@ | |||
| PARAMETER_VERSION = Version.parse("5.3.0") | |||
There was a problem hiding this comment.
Does the version need bumping with these changes?
There was a problem hiding this comment.
Strictly speaking, I guess since the changes are additions to the interface rather than changes to existing it would be a micro-version increment.
TBH I think the parameter versioning is not terribly important at the moment. We don't persist these parameter models anywhere and so far the only users are GDA, the as-yet non-existent hyperion-supervisor, and the external callbacks (via bluesky events). These all get corresponding changes whenever the parameter models are changed. So the chance of client and servers interacting with a different version of the parameter model is pretty minimal.
PARAMETER_VERSION doesn't appear to have changed for almost exactly a year, and I'm sure we've made other changes since then so I think it is kind of just stuck on 5.3.0 for the time being until there is a need to change it.
Fix unit tests
0671ffd to
da524f4
Compare
Preparatory work for
Requires:
This updates the
PlanRunnerto make themove_to_udc_default_stateandclean_up_udcplans something that is invoked using the same mechanism as the mainload_centre_collect_fullplan.PlanRunner is further subclasses into an
InProcessRunnerin anticipation of implementing a sibling class which implements plan execution using a BlueAPI client to a remote server.Instructions to reviewer on how to test:
Checks for reviewer