Conversation
b0333b3 to
16adefc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #699 +/- ##
==========================================
- Coverage 92.28% 92.26% -0.03%
==========================================
Files 54 54
Lines 2269 2263 -6
==========================================
- Hits 2094 2088 -6
Misses 175 175
🚀 New features to boost your workflow:
|
16adefc to
b79b9f4
Compare
f2f2bbe to
8910925
Compare
8910925 to
faba747
Compare
0bbd027 to
d6a0fa3
Compare
- improve docs - replace tenary expressions by ifelse for better GPU performance - improve type stability
d6a0fa3 to
69c2434
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors to the
IceNucleation.jlmodule, focusing on enhancing documentation, simplifying function signatures, and improving parameter handling. The changes clarify the scientific basis for each function, improve usability, and ensure more robust error handling. The most important changes are grouped below by theme.Documentation and Scientific References