Skip to content

rft: heterogeneous ice nucleation#699

Merged
haakon-e merged 2 commits intomainfrom
he/rft-het-nuc
Mar 22, 2026
Merged

rft: heterogeneous ice nucleation#699
haakon-e merged 2 commits intomainfrom
he/rft-het-nuc

Conversation

@haakon-e
Copy link
Copy Markdown
Member

@haakon-e haakon-e commented Mar 11, 2026

This pull request refactors to the IceNucleation.jl module, focusing on enhancing documentation, simplifying function signatures, and improving parameter handling. The changes clarify the scientific basis for each function, improve usability, and ensure more robust error handling. The most important changes are grouped below by theme.

Documentation and Scientific References

  • Rewrote and expanded documentation for all major functions, including detailed descriptions, argument lists, return values, and scientific references (e.g., Mohler2006, China2017, Frostenberg2023, Koop2000). This makes the code much easier to understand and maintain. [1] [2]

@haakon-e haakon-e force-pushed the he/rft-het-nuc branch 2 times, most recently from b0333b3 to 16adefc Compare March 12, 2026 21:53
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.26%. Comparing base (c909c1a) to head (69c2434).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #699      +/-   ##
==========================================
- Coverage   92.28%   92.26%   -0.03%     
==========================================
  Files          54       54              
  Lines        2269     2263       -6     
==========================================
- Hits         2094     2088       -6     
  Misses        175      175              
Components Coverage Δ
src 93.26% <100.00%> (-0.02%) ⬇️
ext 69.47% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trontrytel trontrytel added the P3 Predicted particle properties label Mar 13, 2026
@haakon-e haakon-e force-pushed the he/rft-het-nuc branch 2 times, most recently from f2f2bbe to 8910925 Compare March 17, 2026 23:15
@trontrytel trontrytel added the Needs review Please review my pull request label Mar 18, 2026
@haakon-e haakon-e requested a review from trontrytel March 18, 2026 21:35
Copy link
Copy Markdown
Member

@trontrytel trontrytel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@trontrytel trontrytel added Approved 🍀 and removed Needs review Please review my pull request labels Mar 18, 2026
@haakon-e haakon-e force-pushed the he/rft-het-nuc branch 5 times, most recently from 0bbd027 to d6a0fa3 Compare March 19, 2026 21:22
- improve docs
- replace tenary expressions by ifelse for better GPU performance
- improve type stability
@haakon-e haakon-e merged commit 92c83e1 into main Mar 22, 2026
17 of 27 checks passed
@haakon-e haakon-e deleted the he/rft-het-nuc branch March 22, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved 🍀 P3 Predicted particle properties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants