Skip to content

Plane: quadplane: transition: only set TECS throttle min in auto throttle modes - #33972

Merged
IamPete1 merged 2 commits into
ArduPilot:masterfrom
IamPete1:TECS_throttle_step
Aug 11, 2026
Merged

Plane: quadplane: transition: only set TECS throttle min in auto throttle modes#33972
IamPete1 merged 2 commits into
ArduPilot:masterfrom
IamPete1:TECS_throttle_step

Conversation

@IamPete1

@IamPete1 IamPete1 commented Aug 6, 2026

Copy link
Copy Markdown
Member

Summary

Fixes #33871

This changes to only set TECS throttle min in auto throttle modes where TECS is run. Currently thottle min is set in all cases, if there transition is into a mode which does not use TESC that throttle min does not apply until the next mode change.

Classification & Testing (check all that apply and add your own)

  • Checked by a human programmer
  • Non-functional change
  • No-binary change
  • Infrastructure change (e.g. unit tests, helper scripts)
  • Automated test(s) verify changes (e.g. unit test, autotest)
  • Tested manually, description below (e.g. SITL)
  • Tested on hardware
  • Logs attached
  • Logs available on request

Description

@tridge

tridge commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Automated review note — AI-generated (Claude), cross-checked by an independent second model against the live diff. Please sanity-check before acting.

Reviewed at head bd4d6be04e.

Verdict: COMMENT

  • NOTETools/autotest/quadplane.py:58Test docstring is copy-pasted from a roll test. DetectThrottleSpike's docstring reads "Checks for steps in roll demand" — it checks throttle (servo3_raw).

  • NOTETools/autotest/quadplane.py:73Raises bare Exception where the file uses NotAchievedException. raise Exception("Throttle spike"), while hook_removed() eight lines earlier correctly raises NotAchievedException, as does the rest of quadplane.py.

Full report: https://uav.tridgell.net/DevCallReviews/2026_08_11/devcall_pr_reviews.html

@IamPete1
IamPete1 force-pushed the TECS_throttle_step branch 2 times, most recently from f9ed0d8 to 32587da Compare August 10, 2026 22:47
@IamPete1

Copy link
Copy Markdown
Member Author

I have fixed both the AI reported CI issues.

@rmackay9 rmackay9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really qualified but it looks OK to me

@peterbarker peterbarker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread Tools/autotest/quadplane.py Outdated
Comment thread Tools/autotest/quadplane.py Outdated
Comment thread Tools/autotest/quadplane.py Outdated
Comment thread Tools/autotest/quadplane.py Outdated
@IamPete1
IamPete1 force-pushed the TECS_throttle_step branch from 23fa72f to 1202716 Compare August 11, 2026 01:49
@IamPete1
IamPete1 force-pushed the TECS_throttle_step branch from 1202716 to 7790e07 Compare August 11, 2026 01:51
@IamPete1
IamPete1 requested a review from peterbarker August 11, 2026 01:52
@peterbarker

Copy link
Copy Markdown
Contributor

CI failed the QAUTOTUNE thing. Candidate fix is at #33628 Restarting it

@IamPete1
IamPete1 merged commit cee8714 into ArduPilot:master Aug 11, 2026
83 of 84 checks passed
@Georacer Georacer moved this from Pending to 4.7.1-beta1 in 4.7 Backports Aug 11, 2026
@Georacer Georacer mentioned this pull request Aug 11, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 4.7.1-beta1

Development

Successfully merging this pull request may close these issues.

Plane 4.7 regression: forward-throttle blip entering CRUISE/FBWB after a tiltrotor transition flown out in FBWA (from #29696)

6 participants