Skip to content

fix: Handle already-linked app in re-deploy scenarios#224

Open
guillaumebadin wants to merge 4 commits into47ng:masterfrom
beyond-scale-group:master
Open

fix: Handle already-linked app in re-deploy scenarios#224
guillaumebadin wants to merge 4 commits into47ng:masterfrom
beyond-scale-group:master

Conversation

@guillaumebadin
Copy link

Unlink app before linking to gracefully handle re-runs (e.g., PR synchronize events) where the app is already linked.

Fixes: #222

Unlink app before linking to gracefully handle re-runs
(e.g., PR synchronize events) where the app is already linked.

Fixes: 47ng#222
@github-actions
Copy link

⚠️  Manual approval required

A repository owner must approve the Docker preview deployment for this PR.

PR Author: @guillaumebadin
Head SHA: 75209f118ee0980eb03e84c4d25fae9958375d94

Review and approve in Actions →

Provides architecture overview, build/test/lint commands, and code style conventions for future Claude Code instances working on this GitHub Action.

Co-authored-by: GitHub Actions Bot <[email protected]>
Co-authored-by: Claude Haiku 4.5 <[email protected]>
* chore: Bump clever-tools to 4.6.1 and fix unlink-first test indices

Updates clever-tools dependency from ^4.1.0 to ^4.6.1. Fixes test assertions
that were not accounting for the unlink-before-link idempotency pattern
introduced in commit 75209f1.

Co-Authored-By: Claude Haiku 4.5 <[email protected]>

* chore: Prepare v2.2.0 release for beyond-scale-group

Bump version to 2.2.0 and update all Docker image references from
47ng/actions-clever-cloud to beyond-scale-group/actions-clever-cloud.

Co-Authored-By: Claude Opus 4.6 <[email protected]>

---------

Co-authored-by: GitHub Actions Bot <[email protected]>
Co-authored-by: Claude Haiku 4.5 <[email protected]>
The name "Deploy to Clever Cloud" is already taken on the GitHub
Marketplace. Rename to "BSG Deploy to Clever Cloud" so it can be
published.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@guillaumebadin
Copy link
Author

guillaumebadin commented Feb 24, 2026

hey @franky47 je sais pas si tu maintient encore ce repo.
En fait, on va avoir besoin de faire évoluer et de maintenir ce repo, et vu que certains bouts code concernaient plus le repo beyond scale group.

En fait, ma question, c'est : est-ce que tu continues à maintenir le repo, ou est-ce que tu veux qu'on s'en charge?

Allez, merci.

@github-actions
Copy link

🐳  Docker image preview

Preview this PR in your workflow:

# Use the PR number to follow changes in this PR
- uses: docker://ghcr.io/47ng/actions-clever-cloud:pr-224

# Use the git SHA for pinning to a specific commit
- uses: docker://ghcr.io/47ng/actions-clever-cloud:git-75209f118ee0980eb03e84c4d25fae9958375d94
Image metadata

Digest: sha256:3d64bd1565f15759db86a3abd6d06949d30afb4765c26f454eb99c725d61f779

📌  Tags

ghcr.io/47ng/actions-clever-cloud:pr-224
ghcr.io/47ng/actions-clever-cloud:git-75209f118ee0980eb03e84c4d25fae9958375d94

🏷  Labels

org.opencontainers.image.title=47ng/actions-clever-cloud
org.opencontainers.image.description=GitHub action to deploy to Clever Cloud (PR preview)
org.opencontainers.image.version=2.1.0-pr.224
org.opencontainers.image.revision=75209f118ee0980eb03e84c4d25fae9958375d94
org.opencontainers.image.licenses=MIT
org.opencontainers.image.source=https://github.com/47ng/actions-clever-cloud/tree/75209f118ee0980eb03e84c4d25fae9958375d94
org.opencontainers.image.documentation=https://github.com/47ng/actions-clever-cloud/pull/224
org.opencontainers.image.url=https://github.com/47ng/actions-clever-cloud/actions/runs/22347288083

🤖 This comment is updated on every push

Copy link
Member

@franky47 franky47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the core issue solved by this PR? From the change in action.ts, it feels like this could be solved by linking the app once on a dev machine, and versioning the .clever.json file, as indicated in the docs.

As for the rest of the PR, see the review comments.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Rename this file to AGENTS.md for cross-agent configuration (hopefully one day Claude Code can align to the rest of the ecosystem, but I'm more in favour of OSS harnesses who follow a similar convention).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: delete this file, we're using pnpm.

runs:
using: docker
image: docker://ghcr.io/47ng/actions-clever-cloud:2.1.0
image: docker://ghcr.io/beyond-scale-group/actions-clever-cloud:2.2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: If you want to use your own image registry, feel free to fork this repository, but I can't merge this as-is.

Comment on lines +128 to +129
echo "ghcr.io/beyond-scale-group/actions-clever-cloud:${{ steps.docker-tag.outputs.tag }}" >> $GITHUB_OUTPUT
echo "ghcr.io/beyond-scale-group/actions-clever-cloud:git-${{ steps.sha.outputs.sha }}" >> $GITHUB_OUTPUT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: If you want to use your own image registry, feel free to fork this repository, but I can't merge this as-is.

Comment on lines +181 to +184
- uses: docker://ghcr.io/beyond-scale-group/actions-clever-cloud:${{ steps.docker-tag.outputs.tag }}

# Use the git SHA for pinning to a specific commit
- uses: docker://ghcr.io/47ng/actions-clever-cloud:git-${{ steps.sha.outputs.sha }}
- uses: docker://ghcr.io/beyond-scale-group/actions-clever-cloud:git-${{ steps.sha.outputs.sha }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: If you want to use your own image registry, feel free to fork this repository, but I can't merge this as-is.

echo "47ng/actions-clever-cloud:${{ steps.docker-tag.outputs.tag }}" >> $GITHUB_OUTPUT
echo "47ng/actions-clever-cloud:git-${{ steps.sha.outputs.sha }}" >> $GITHUB_OUTPUT
echo "ghcr.io/beyond-scale-group/actions-clever-cloud:${{ steps.docker-tag.outputs.tag }}" >> $GITHUB_OUTPUT
echo "ghcr.io/beyond-scale-group/actions-clever-cloud:git-${{ steps.sha.outputs.sha }}" >> $GITHUB_OUTPUT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: If you want to use your own image registry, feel free to fork this repository, but I can't merge this as-is.

@guillaumebadin
Copy link
Author

Hello @franky47 ,

Thank you for the response. The problem is we have multiple monorepo repositories with multiple JSONs, so it's a mess when we try to deploy. I will clean the request and propose you a cleaner. Thank you for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clever link fails when app is already linked (re-deploy scenario)

3 participants