fix: Handle already-linked app in re-deploy scenarios#224
fix: Handle already-linked app in re-deploy scenarios#224guillaumebadin wants to merge 4 commits into47ng:masterfrom
Conversation
Unlink app before linking to gracefully handle re-runs (e.g., PR synchronize events) where the app is already linked. Fixes: 47ng#222
|
Provides architecture overview, build/test/lint commands, and code style conventions for future Claude Code instances working on this GitHub Action. Co-authored-by: GitHub Actions Bot <[email protected]> Co-authored-by: Claude Haiku 4.5 <[email protected]>
* chore: Bump clever-tools to 4.6.1 and fix unlink-first test indices Updates clever-tools dependency from ^4.1.0 to ^4.6.1. Fixes test assertions that were not accounting for the unlink-before-link idempotency pattern introduced in commit 75209f1. Co-Authored-By: Claude Haiku 4.5 <[email protected]> * chore: Prepare v2.2.0 release for beyond-scale-group Bump version to 2.2.0 and update all Docker image references from 47ng/actions-clever-cloud to beyond-scale-group/actions-clever-cloud. Co-Authored-By: Claude Opus 4.6 <[email protected]> --------- Co-authored-by: GitHub Actions Bot <[email protected]> Co-authored-by: Claude Haiku 4.5 <[email protected]>
The name "Deploy to Clever Cloud" is already taken on the GitHub Marketplace. Rename to "BSG Deploy to Clever Cloud" so it can be published. Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
hey @franky47 je sais pas si tu maintient encore ce repo. En fait, ma question, c'est : est-ce que tu continues à maintenir le repo, ou est-ce que tu veux qu'on s'en charge? Allez, merci. |
🐳 Docker image previewPreview this PR in your workflow: # Use the PR number to follow changes in this PR
- uses: docker://ghcr.io/47ng/actions-clever-cloud:pr-224
# Use the git SHA for pinning to a specific commit
- uses: docker://ghcr.io/47ng/actions-clever-cloud:git-75209f118ee0980eb03e84c4d25fae9958375d94Image metadataDigest: 📌 Tags🏷 Labels🤖 This comment is updated on every push |
franky47
left a comment
There was a problem hiding this comment.
What's the core issue solved by this PR? From the change in action.ts, it feels like this could be solved by linking the app once on a dev machine, and versioning the .clever.json file, as indicated in the docs.
As for the rest of the PR, see the review comments.
There was a problem hiding this comment.
suggestion: Rename this file to AGENTS.md for cross-agent configuration (hopefully one day Claude Code can align to the rest of the ecosystem, but I'm more in favour of OSS harnesses who follow a similar convention).
There was a problem hiding this comment.
issue: delete this file, we're using pnpm.
| runs: | ||
| using: docker | ||
| image: docker://ghcr.io/47ng/actions-clever-cloud:2.1.0 | ||
| image: docker://ghcr.io/beyond-scale-group/actions-clever-cloud:2.2.0 |
There was a problem hiding this comment.
issue: If you want to use your own image registry, feel free to fork this repository, but I can't merge this as-is.
| echo "ghcr.io/beyond-scale-group/actions-clever-cloud:${{ steps.docker-tag.outputs.tag }}" >> $GITHUB_OUTPUT | ||
| echo "ghcr.io/beyond-scale-group/actions-clever-cloud:git-${{ steps.sha.outputs.sha }}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
issue: If you want to use your own image registry, feel free to fork this repository, but I can't merge this as-is.
| - uses: docker://ghcr.io/beyond-scale-group/actions-clever-cloud:${{ steps.docker-tag.outputs.tag }} | ||
|
|
||
| # Use the git SHA for pinning to a specific commit | ||
| - uses: docker://ghcr.io/47ng/actions-clever-cloud:git-${{ steps.sha.outputs.sha }} | ||
| - uses: docker://ghcr.io/beyond-scale-group/actions-clever-cloud:git-${{ steps.sha.outputs.sha }} |
There was a problem hiding this comment.
issue: If you want to use your own image registry, feel free to fork this repository, but I can't merge this as-is.
| echo "47ng/actions-clever-cloud:${{ steps.docker-tag.outputs.tag }}" >> $GITHUB_OUTPUT | ||
| echo "47ng/actions-clever-cloud:git-${{ steps.sha.outputs.sha }}" >> $GITHUB_OUTPUT | ||
| echo "ghcr.io/beyond-scale-group/actions-clever-cloud:${{ steps.docker-tag.outputs.tag }}" >> $GITHUB_OUTPUT | ||
| echo "ghcr.io/beyond-scale-group/actions-clever-cloud:git-${{ steps.sha.outputs.sha }}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
issue: If you want to use your own image registry, feel free to fork this repository, but I can't merge this as-is.
|
Hello @franky47 , Thank you for the response. The problem is we have multiple monorepo repositories with multiple JSONs, so it's a mess when we try to deploy. I will clean the request and propose you a cleaner. Thank you for the feedback. |
Unlink app before linking to gracefully handle re-runs (e.g., PR synchronize events) where the app is already linked.
Fixes: #222