forked from 47ng/actions-clever-cloud
-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Context
PR 47ng/actions-clever-cloud#224 received a review from @franky47 with changes requested. The upstream maintainer is willing to accept the core fix but not the BSG-specific changes.
Franky47's feedback summary
Core concern
He wants a cleaner justification for the unlink-before-link pattern — specifically why versioning .clever.json doesn't work in our case (monorepo with multiple .clever.json files).
Inline review comments
CLAUDE.md→ Rename toAGENTS.mdfor cross-agent conventionpackage-lock.json→ Delete it, the project uses pnpm onlyaction.yml+ workflows (4 comments) → Revert all Docker registry references frombeyond-scale-groupback to47ng. Quote: "If you want to use your own image registry, feel free to fork this repository, but I can't merge this as-is."
Action items
- Create a clean upstream PR on
47ng/actions-clever-cloudwith ONLY the core fix (unlink-before-linkinaction.ts+ tests), without any BSG-specific changes (no registry rename, no version bump, no CLAUDE.md) - Add a clear PR description explaining the monorepo use case where
.clever.jsonversioning doesn't work - Delete
package-lock.jsonfrom the upstream PR - Keep all BSG-specific changes (registry, branding, CLAUDE.md) on our fork only
- Consider renaming
CLAUDE.mdtoAGENTS.mdon our fork as well (optional)
Reference
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels