Skip to content

Clean up PR #224 upstream: address franky47 review feedback #3

@guillaumebadin

Description

@guillaumebadin

Context

PR 47ng/actions-clever-cloud#224 received a review from @franky47 with changes requested. The upstream maintainer is willing to accept the core fix but not the BSG-specific changes.

Franky47's feedback summary

Core concern

He wants a cleaner justification for the unlink-before-link pattern — specifically why versioning .clever.json doesn't work in our case (monorepo with multiple .clever.json files).

Inline review comments

  1. CLAUDE.md → Rename to AGENTS.md for cross-agent convention
  2. package-lock.json → Delete it, the project uses pnpm only
  3. action.yml + workflows (4 comments) → Revert all Docker registry references from beyond-scale-group back to 47ng. Quote: "If you want to use your own image registry, feel free to fork this repository, but I can't merge this as-is."

Action items

  • Create a clean upstream PR on 47ng/actions-clever-cloud with ONLY the core fix (unlink-before-link in action.ts + tests), without any BSG-specific changes (no registry rename, no version bump, no CLAUDE.md)
  • Add a clear PR description explaining the monorepo use case where .clever.json versioning doesn't work
  • Delete package-lock.json from the upstream PR
  • Keep all BSG-specific changes (registry, branding, CLAUDE.md) on our fork only
  • Consider renaming CLAUDE.md to AGENTS.md on our fork as well (optional)

Reference

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions