Parser friendly, more complete logs#97
Open
BuonOmo wants to merge 2 commits into
Open
Conversation
Reaper status logs are printed even if we are killing a worker, and they show information for each worker. Information is presented in a key=value fashion which is way easier to parse, and correctly handled by most log analysis tools. Since this is breaking former log parsing, I've taken the liberty to also clarify logs, showing that master is included in the total. Signed-off-by: Ulysse Buonomo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reaper status logs are printed even if we are killing a worker, and they
show information for each worker. Information is presented in a key=value
fashion which is way easier to parse, and correctly handled by most log
analysis tools.
Since this is breaking former log parsing, I've taken the liberty to
also clarify logs, showing that master is included in the total.
NOTES:
I'd be glad to leave rebase on top of if, leaving the credit to the
original author,
set_workers, I did not add any. YetI could add some for
set_master_memoryif it feels right.parsing. Yet I don't think it is necessary!
Thank you for that very useful gem 🙂 (and all of your work!)
Ulysse