Skip </dev/tty redirect when stdin is already a terminal#693
Merged
WhyNotHugo merged 1 commit intozk-org:devfrom Apr 9, 2026
Merged
Conversation
WhyNotHugo
approved these changes
Apr 8, 2026
Contributor
WhyNotHugo
left a comment
WhyNotHugo
left a comment
There was a problem hiding this comment.
LGTM, I'd just keep the comment short and concise.
Contributor
Author
|
Thank you for the review. I agree completely with your points - it was a bit wordy. |
The </dev/tty redirect was unconditionally appended to the editor command to fix vim when stdin is a pipe (see zk-org#4). However, this breaks TUI editors that use crossterm for terminal I/O (e.g. fresh) — the redirected fd causes a blank screen. Only apply the redirect when stdin is actually a pipe, which is the only case where it is needed.
WhyNotHugo
force-pushed
the
fix/skip-dev-tty-redirect-when-stdin-is-terminal
branch
from
5340d0c to
53a3732
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The </dev/tty redirect was unconditionally appended to the editor command to fix vim when stdin is a pipe (see #4). However, this breaks TUI editors that use crossterm for terminal I/O (e.g. fresh) — the redirected fd causes a blank screen.
Only apply the redirect when stdin is actually a pipe, which is the only case where it is needed.
...
fixes #692