Use stackless traversal for tree destruction to avoid stack overflow#702
Merged
Use stackless traversal for tree destruction to avoid stack overflow#702
Conversation
For very deep trees that can be parsed using our stackless parser, attempts to remove the relevant nodes may cause a stack overflow due to deep recursion. Instead, use a stackless traversal; this is a little different from other traversals we already have in the library, as it needs to process each node *after* the entire subtree to avoid accessing destroyed memory. This is part of a new destroy_tree function; destroy_node now only destroys the node's attributes/name/value.
This would have previously failed in some configurations due to a recursive implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For very deep trees that can be parsed using our stackless parser,
attempts to remove the relevant nodes may cause a stack overflow due to
deep recursion.
Instead, use a stackless traversal; this is a little different from
other traversals we already have in the library, as it needs to process
each node after the entire subtree to avoid accessing destroyed
memory.
Fixes #701.