Mcuxa lpdac test harness enhancement for second serial console checking with latest multi-dut support in twister-pytest - #112258
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds DAC (nxp,lpdac) support to the FRDM-MCXA266/346/366 boards. It defines the dac0 node in the shared SoC dtsi, enables/clocks it on the boards, adds DAC0 pinmux, updates board capability lists, and wires up the DAC sample plus a new pytest-based DAC API test that reads ztest results from the auxiliary UART (the DAC output pin conflicts with the default console LPUART2, so overlays move the console to LPUART3). It depends on PR #91338.
Changes:
- Adds
dac0to the SoC dtsi and enables it on the three boards (board_common.dtsi, board.c clocks, pinctrl, board YAMLs). - Adds sample/test overlays moving console to LPUART3 plus README documentation.
- Adds a pytest harness test reading DAC ztest output over a secondary UART.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| dts/arm/nxp/mcx/nxp_mcxaxx6_common.dtsi | Adds disabled dac0 node for the SoC |
| boards/nxp/frdm_mcxaxx6/board_common.dtsi | Enables dac0 with DAC0 pinmux by default |
| boards/nxp/frdm_mcxaxx6/board.c | Adds SPC/clock init for DAC0 |
| boards/nxp/frdm_mcxaxx6/frdm_mcxa{266,346,366}-pinctrl.dtsi | Adds pinmux_dac0 on P2_2 |
| boards/nxp/frdm_mcxaxx6/frdm_mcxa{266,346,366}.yaml | Lists dac as supported |
| samples/drivers/dac/boards/frdm_mcxa{266,346,366}.overlay | DAC sample overlays, console to LPUART3 |
| samples/drivers/dac/README.rst | Documents building/running on the three boards |
| tests/drivers/dac/dac_api/boards/frdm_mcxa{266,346,366}.overlay | Test console overlays |
| tests/drivers/dac/dac_api/testcase.yaml | Adds pytest DAC test entry |
| tests/drivers/dac/dac_api/pytest/test_dac.py | Verifies DAC ztest output on aux UART |
30a1f8f to
46942f4
Compare
martinjaeger
left a comment
There was a problem hiding this comment.
I don't fully understand why this is needed. Also the changes don't have anything to do with Mcux lpdac so far, so the title is misleading. Can you please clarify?
@martinjaeger, this is because we are using a different UART for this particular case for those platforms, but still use default uart for other application, to make the CI can support such variation, this is necessary. otherwise, this board can only run pass with this case, all others fails. and this is only for |
d4f94af to
6964cba
Compare
|
@martinjaeger I update the title, this pr is about testing harness setting. Thanks |
eecbf52 to
6efa531
Compare
fbc7b62 to
efb2c60
Compare
Convert LPDAC test to pytest using DeviceAdapter on AUX UART (index 1). Update tests.yaml to harness: pytest and set pytest_root to test file. Consolidate LineMatcher checks into one ordered call per review feedback. Improves CI reliability for MCX Ax x6 boards using AUX serial output. Signed-off-by: Hake Huang <hake.huang@nxp.com>
efb2c60 to
d37802e
Compare
|



this depends on #91338