Add playback speed controls to all video players#288
Open
aarya-brex wants to merge 2 commits intozellij-org:mainfrom
Open
Add playback speed controls to all video players#288aarya-brex wants to merge 2 commits intozellij-org:mainfrom
aarya-brex wants to merge 2 commits intozellij-org:mainfrom
Conversation
Switch from @clappr/player to the legacy clappr package and add the clappr-playback-rate-plugin to both video shortcodes. This adds a speed selector (0.5x, 1x, 1.5x, 2x) to the player control bar on all 14 pages with embedded videos. Also fix an invalid escaped quote in colliding-keybindings.md frontmatter that broke Hugo builds with newer versions.
Clappr was only used for basic MP4 playback with no advanced features. Plyr is lighter, has built-in playback speed controls, and eliminates the need for a separate plugin dependency.
Author
|
@imsnif, mind taking a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
colliding-keybindings.mdfrontmatter that broke Hugo buildsTest plan
/tutorials/basic-functionality/) and verify the Plyr video player renders/news/config-command-layouts/) and left-aligned (/tutorials/basic-functionality/)