Narrow tag of function declaration captures#21
Merged
MrSubidubi merged 1 commit intozed-extensions:mainfrom Feb 2, 2026
Merged
Narrow tag of function declaration captures#21MrSubidubi merged 1 commit intozed-extensions:mainfrom
MrSubidubi merged 1 commit intozed-extensions:mainfrom
Conversation
Following builtin python, we tag function declaration captures with `@function.definition` instead of `@function`. See https://github.com/zed-industries/zed/blob/e1a09e290c48fc02d07aaf2150856d77996414df/crates/languages/src/python/highlights.scm#L52. This fixes highlighting for themes making the distinction between declarations and calls. One such theme is Alabaster, see https://github.com/tsimoshka/zed-theme-alabaster/blob/124750e2cab8a7fbfdaf26c7ccfc5fa0ba1d0541/themes/alabaster-color-theme.json#L242.
MrSubidubi
approved these changes
Feb 2, 2026
Contributor
MrSubidubi
left a comment
MrSubidubi
left a comment
There was a problem hiding this comment.
Good catch and nice context, thanks for providing it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following builtin python, we tag function declaration captures with
@function.definitioninstead of@function. See https://github.com/zed-industries/zed/blob/e1a09e290c48fc02d07aaf2150856d77996414df/crates/languages/src/python/highlights.scm#L52.This fixes highlighting for themes making the distinction between declarations and calls. One such theme is Alabaster, see https://github.com/tsimoshka/zed-theme-alabaster/blob/124750e2cab8a7fbfdaf26c7ccfc5fa0ba1d0541/themes/alabaster-color-theme.json#L242.