RFC: avoid direct mutation to ndarray.shape attributes (3) #5365
+9
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
force-pushed
the
compat/shape-attr-mut
branch
from
252e71f to
ec7ad25
Compare
chrishavlin
requested changes
Feb 4, 2026
Contributor
chrishavlin
left a comment
chrishavlin
left a comment
There was a problem hiding this comment.
one spot that needs a fix
neutrinoceros
force-pushed
the
compat/shape-attr-mut
branch
from
ec7ad25 to
ce653ef
Compare
chrishavlin
approved these changes
Feb 4, 2026
meeseeksmachine
pushed a commit
to meeseeksmachine/yt
that referenced
this pull request
Feb 4, 2026
…ape attributes (3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Follow up to #5307 and #5309
PR Checklist