Refactor: Move derived_field_list to field_info#5224
Draft
chrishavlin wants to merge 2 commits intoyt-project:mainfrom
Draft
Refactor: Move derived_field_list to field_info#5224chrishavlin wants to merge 2 commits intoyt-project:mainfrom
derived_field_list to field_info#5224chrishavlin wants to merge 2 commits intoyt-project:mainfrom
Conversation
chrishavlin
added
enhancement
chrishavlin
commented
Jul 21, 2025
| def derived_field_list(self): | ||
| self.index | ||
| return self.field_info.derived_field_list | ||
|
|
Contributor
Author
There was a problem hiding this comment.
just occurred to me that I should add a setter here for the sake of downstream frontends.
Contributor
|
Broadly I like this idea--wondering if there are any potential performance changes related to accessing it from the |
brittonsmith
reviewed
Aug 4, 2025
Member
brittonsmith
left a comment
brittonsmith
left a comment
There was a problem hiding this comment.
I like this as a consolidation of duties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR moves the
derived_field_listto an attribute within the dataset'sfield_infocontainer to help with #5214 . I have a follow up with the same change for thefield_list, but that's much more invasive, so wanted to check how this smaller changeset does in the test suite (but the change here can be merged on its own).