Add conditional CSS class arrays to all *Class() methods#143
Open
WarLikeLaux wants to merge 1 commit intoyiisoft:masterfrom
Open
Add conditional CSS class arrays to all *Class() methods#143WarLikeLaux wants to merge 1 commit intoyiisoft:masterfrom
*Class() methods#143WarLikeLaux wants to merge 1 commit intoyiisoft:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #143 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 283 288 +5
===========================================
Files 8 8
Lines 892 902 +10
===========================================
+ Hits 892 902 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Extends all 29
*Class()methods inAlert,Dropdown, andMenuto acceptstring|array. The array format supports conditional CSS classes (Laravel Blade pattern).Keys with
truevalues are included,falseare excluded. Numeric keys are always included. This replaces ternary expressions like->class($active ? 'nav active' : 'nav').Resolution logic is in
Normalizer::cssClasses(). No BC break, existing string calls work unchanged.