Remove raw keys from normalized items in Normalizer#132
Open
WarLikeLaux wants to merge 1 commit intoyiisoft:masterfrom
Open
Remove raw keys from normalized items in Normalizer#132WarLikeLaux wants to merge 1 commit intoyiisoft:masterfrom
Normalizer#132WarLikeLaux wants to merge 1 commit intoyiisoft:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #132 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 283 283
===========================================
Files 8 8
Lines 892 904 +12
===========================================
+ Hits 892 904 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Normalizer::dropdown()andNormalizer::menu()extracticon,iconAttributes,iconClass,iconContainerAttributesvia helper methods and pass them torenderLabel(). Thelabel()helper also readsencode. After extraction, these keys stay in the normalized item array alongside the processed results (label,active,link, etc.).This PR adds
unset()for these five keys after they are consumed, so the normalized output only contains processed data.Neither
DropdownnorMenuread these keys from normalized items, so removing them is safe.No BC break: the normalized array is internal, not part of the public API.