Skip to content

Add missing ARIA attributes to Dropdown, Menu, and Alert#118

Open
WarLikeLaux wants to merge 3 commits intoyiisoft:masterfrom
WarLikeLaux:fix-aria-attributes
Open

Add missing ARIA attributes to Dropdown, Menu, and Alert#118
WarLikeLaux wants to merge 3 commits intoyiisoft:masterfrom
WarLikeLaux:fix-aria-attributes

Conversation

@WarLikeLaux
Copy link
Contributor

Q A
Is bugfix? ✔️
New feature?
Tests added? ✔️
Breaks BC?
Fixed issues

What does this PR do?

Add missing ARIA attributes: aria-disabled for disabled items in Dropdown and Menu, aria-current="page" instead of "true" in Dropdown, and default aria-label="Close" on Alert close button.

@WarLikeLaux WarLikeLaux marked this pull request as ready for review March 22, 2026 13:04
@codecov
Copy link

codecov bot commented Mar 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e57424b) to head (62135bb).

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #118   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       283       284    +1     
===========================================
  Files              8         8           
  Lines            892       897    +5     
===========================================
+ Hits             892       897    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant