Fix documentation around Expires header#1909
Fix documentation around Expires header#1909menelaos wants to merge 3 commits intoyesodweb:masterfrom
Expires header#1909Conversation
|
|
||
| {- | Get the time 365 days from now in RFC 1123 format. For use as an expiry | ||
| date on a resource that never expires. See RFC 2616 section 14.21 for details. | ||
| date on a resource that never expires. See RFC 9111 section 5.3 for details. |
There was a problem hiding this comment.
RFC 2616 has been obsoleted by RFC 7234, which in turn has been obsoleted by RFC 9111.
Side note:
Initially, the expiry date was set to the year 2037. This was changed in #870.
The newer standard theoretically permits longer lifetimes but I think it doesn't hurt to keep the current behaviour. The relevant passage:
Historically, HTTP required the Expires field value to be no more than a year in the future. While longer freshness lifetimes are no longer prohibited, extremely large values have been demonstrated to cause problems (e.g., clock overflows due to use of 32-bit integers for time values), and many caches will evict a response far sooner than that.
|
The current CI failure should be unrelated to the changes here. |
Before submitting your PR, check that you've:
@sincedeclarations to the Haddocks for new, public APIsAfter submitting your PR: