Skip to content

don't parameterize [A|M|W]Form based on monad, instead use site#1895

Open
mixphix wants to merge 1 commit intoyesodweb:masterfrom
mixphix:form-for-app
Open

don't parameterize [A|M|W]Form based on monad, instead use site#1895
mixphix wants to merge 1 commit intoyesodweb:masterfrom
mixphix:form-for-app

Conversation

@mixphix
Copy link
Copy Markdown
Contributor

@mixphix mixphix commented Dec 24, 2025

Before submitting your PR, check that you've:

  • Bumped the version number

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Greatly simplifies the type signatures and concretizes the monad in which things happen (namely HandlerFor site), but comes at the cost of no longer having MonadTrans AForm and potentially writing a few more liftHandlers.

The version numbers are suggestions, perhaps this is big enough to bump to 2.0, perhaps just to 1.8, I'll leave that to your discretion.

@parsonsmatt
Copy link
Copy Markdown
Collaborator

The change here is pretty significant and I don't see much benefit. While I do like this design more than the prior one, I'd need to be convinced that there's good reason to force all users to upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants