don't parameterize [A|M|W]Form based on monad, instead use site#1895
Open
mixphix wants to merge 1 commit intoyesodweb:masterfrom
Open
don't parameterize [A|M|W]Form based on monad, instead use site#1895mixphix wants to merge 1 commit intoyesodweb:masterfrom
site#1895mixphix wants to merge 1 commit intoyesodweb:masterfrom
Conversation
Collaborator
|
The change here is pretty significant and I don't see much benefit. While I do like this design more than the prior one, I'd need to be convinced that there's good reason to force all users to upgrade. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
After submitting your PR:
Greatly simplifies the type signatures and concretizes the monad in which things happen (namely
HandlerFor site), but comes at the cost of no longer havingMonadTrans AFormand potentially writing a few moreliftHandlers.The version numbers are suggestions, perhaps this is big enough to bump to 2.0, perhaps just to 1.8, I'll leave that to your discretion.