Pull Request — Added Windows & Linux Installers + Code Fixes - #10
Open
the-33 wants to merge 21 commits into
Open
Pull Request — Added Windows & Linux Installers + Code Fixes#10the-33 wants to merge 21 commits into
the-33 wants to merge 21 commits into
Conversation
…nt (read-only property)
fix: fix error when trying to modify property 'prototype' of MicroEve…
add: executable batch file to run the app automaticaly
add: app icon in .png and .ico format
add: installer for Linux (using bash) and Windows (using Inno Setup Compiler)
…e, not in the launcher batchfile and renamed linux installer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request — Added Windows & Linux Installers + Code Fixes
Summary
This Pull Request introduces full installers for Windows and Linux, along with fixes in the JavaScript codebase that improve compatibility, and runtime behavior when the application is executed outside a pure development environment.
What’s Included
1. JavaScript Code Fixes
This PR includes a vital improvement to the original SpriteCow-based codebase to ensure correct execution under modern bundlers (Parcel) and in packaged environments:
Prototype handling fixes
Rewrote prototype assignments to avoid errors such as:
- Cannot assign to read only property 'prototype'and to ensure compatibility with Babel/Parcel-generated class wrappers.
Class + MicroEvent integration rewritten
Ensured that classes
SpriteCanvasView,ImgInput,InlineEdit, andToolbarextendMicroEventcorrectly without overriding protected prototype structures.2. Windows Installer (Inno Setup)
A full Windows installer was created using Inno Setup, including:
yarn devand opens the browser automatically3. Linux Installer Script (
installer.sh)A complete Linux installation script featuring:
.tar.gz/opt/Spritesheet Cutteryarn install)/usr/local/bin.desktopintegration so the app appears in the application menuOutcome
The project now supports cross-platform installation and execution, with a cleaner internal JavaScript structure and a simple workflow for end-users on both Windows and Linux.