Skip to content

fix(endpoints): Add type annotation to endpoints array#42

Merged
GroophyLifefor merged 4 commits intomainfrom
fix/endpoints-type-annotation
Apr 20, 2025
Merged

fix(endpoints): Add type annotation to endpoints array#42
GroophyLifefor merged 4 commits intomainfrom
fix/endpoints-type-annotation

Conversation

@mertssmnoglu
Copy link
Member

  • Ignore no-explicit-any for deno-lint. We don't need strict types for endpoints array

- Ignore no-explicit-any for deno-lint. We don't need strict types for endpoints array

Signed-off-by: Mert Şişmanoğlu <mertssmnoglu@gmail.com>
@mertssmnoglu mertssmnoglu self-assigned this Apr 20, 2025
@GroophyLifefor
Copy link
Member

The generation codes also should updated in

https://github.com/yelixjs/yelix-docs/blob/main/static/resolveEndpoints.ts
and https://github.com/yelixjs/yelix/blob/main/src/core/HMR.ts

https://github.com/yelixjs/yelix/blob/56e124bb014405f98793bb62a864cafae62b73c3/src/core/HMR.ts#L112-L114

We add Ignore comment and any type to generation code so will be updated each yelix developer.

Copy link
Member

@GroophyLifefor GroophyLifefor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…pointsFile

Signed-off-by: Mert Şişmanoğlu <mertssmnoglu@gmail.com>
@mertssmnoglu
Copy link
Member Author

mertssmnoglu commented Apr 20, 2025

The generation codes also should updated in

https://github.com/yelixjs/yelix-docs/blob/main/static/resolveEndpoints.ts and https://github.com/yelixjs/yelix/blob/main/src/core/HMR.ts

https://github.com/yelixjs/yelix/blob/56e124bb014405f98793bb62a864cafae62b73c3/src/core/HMR.ts#L112-L114

We add Ignore comment and any type to generation code so will be updated each yelix developer.

I updated the core HMR file in this repo, I will create a new PR for the docs.

Copy link
Member

@GroophyLifefor GroophyLifefor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump version please?

Copy link
Member

@GroophyLifefor GroophyLifefor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GroophyLifefor GroophyLifefor merged commit 20a6291 into main Apr 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

endpoints variable causes implicit any type error in endpoint generation

2 participants