Skip to content

[NEW RBO] Use canonical statistic names#37981

Merged
alexpaniman merged 1 commit intomainfrom
refactor/use-canonical-row-byte-sizes
Apr 13, 2026
Merged

[NEW RBO] Use canonical statistic names#37981
alexpaniman merged 1 commit intomainfrom
refactor/use-canonical-row-byte-sizes

Conversation

@alexpaniman
Copy link
Copy Markdown
Contributor

Replace RecordsCount and DataSize with a more commonly used and clear ERows (estimated rows) and EBytes (estimated bytes). Also makes it clearer that we don't know the exact counts, only estimates.

@alexpaniman alexpaniman requested a review from a team as a code owner April 12, 2026 20:49
@ydbot
Copy link
Copy Markdown
Collaborator

ydbot commented Apr 12, 2026

Run Extra Tests

Run additional tests for this PR. You can customize:

  • Test Size: small, medium, large (default: all)
  • Test Targets: any directory path (default: ydb/)
  • Sanitizers: ASAN, MSAN, TSAN
  • Coredumps: enable for debugging (default: off)
  • Additional args: custom ya make arguments

▶  Run tests

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2026

2026-04-12 20:53:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for 764b56c has started.
2026-04-12 20:53:36 UTC Artifacts will be uploaded here
2026-04-12 20:55:52 UTC ya make is running...
🟡 2026-04-12 23:13:13 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
49287 45741 0 1 3536 9

2026-04-12 23:13:29 UTC ya make is running... (failed tests rerun, try 2)
🟢 2026-04-12 23:14:21 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11 (only retried tests) 11 0 0 0 0

🟢 2026-04-12 23:14:24 UTC Build successful.
🟢 2026-04-12 23:14:41 UTC ydbd size 2.5 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 75e04a0 merge: 764b56c diff diff %
ydbd size 2 662 222 888 Bytes 2 662 222 888 Bytes 0 Bytes 0.000%
ydbd stripped size 568 305 976 Bytes 568 305 976 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2026

2026-04-12 20:53:22 UTC Pre-commit check linux-x86_64-release-asan for 764b56c has started.
2026-04-12 20:53:40 UTC Artifacts will be uploaded here
2026-04-12 20:56:00 UTC ya make is running...
🟡 2026-04-12 22:40:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18705 18650 0 20 31 4

🟢 2026-04-12 22:40:09 UTC Build successful.
🟢 2026-04-12 22:40:35 UTC ydbd size 4.1 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 75e04a0 merge: 764b56c diff diff %
ydbd size 4 353 671 864 Bytes 4 353 671 768 Bytes -96 Bytes -0.000%
ydbd stripped size 1 635 563 856 Bytes 1 635 563 792 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexpaniman alexpaniman enabled auto-merge (squash) April 13, 2026 04:30
@alexpaniman alexpaniman merged commit 4a9ebb4 into main Apr 13, 2026
11 checks passed
@alexpaniman alexpaniman deleted the refactor/use-canonical-row-byte-sizes branch April 13, 2026 11:40
@ydbot
Copy link
Copy Markdown
Collaborator

ydbot commented Apr 13, 2026

Backport

To backport this PR, click the button next to the target branch and then click "Run workflow" in the Run Actions UI.

Branch Run
stable-25-4, stable-25-4-1, stable-26-1, stable-26-1-1 ▶  Backport
stable-26-1, stable-26-1-1 ▶  Backport
stable-26-1 ▶  Backport

▶  Backport manual

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants