fix(table_service): support both underlying types for YSON bytes and text#2077
Open
ulya-sidorina wants to merge 4 commits intoydb-platform:masterfrom
Open
fix(table_service): support both underlying types for YSON bytes and text#2077ulya-sidorina wants to merge 4 commits intoydb-platform:masterfrom
ulya-sidorina wants to merge 4 commits intoydb-platform:masterfrom
Conversation
43400a9 to
3eea730
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2077 +/- ##
===========================================
- Coverage 72.55% 46.03% -26.52%
===========================================
Files 427 426 -1
Lines 36904 36794 -110
===========================================
- Hits 26774 16937 -9837
- Misses 8944 19230 +10286
+ Partials 1186 627 -559
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3eea730 to
aeb6549
Compare
ON bytes and text
1934147 to
b5ab618
Compare
2d02a3f to
1a48b8d
Compare
1a48b8d to
e405e37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
TableServicescanner handles YSON inconsistently: it expects YSON asTextValue, while other parts of SDK accept YSON as eitherTextValueorBytesValue.As a result, scanning via
TableServicefails when server returns YSON asBytesValue.Issue Number: NYDB-2083
What is the new behavior?
TableServicescanner supports both underlying types for YSON:TextValueandBytesValue.Other information