Conversation
|
@greptile review |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b4a0dc5325
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Implements the “VDisk storage” UI by adding an experimental storage details summary card to the VDisk page (behind the “new storage view” setting) and covering it with E2E + snapshot tests.
Changes:
- Add
VDiskStorageDetailscomponent (metrics + location fields + “Go to PDisk” CTA) gated byuseNewStorageViewEnabled. - Extend VDisk prepared data with
NodeRackand add a unit test for the mapper. - Add Playwright E2E tests + visual snapshots for wide/medium/narrow layouts (Chromium + Safari where applicable).
Reviewed changes
Copilot reviewed 9 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/suites/storage/vdiskPage.test.ts-snapshots/vdisk-storage-details-wide-safari-linux.png | Adds wide-layout Safari snapshot for VDisk storage details. |
| tests/suites/storage/vdiskPage.test.ts-snapshots/vdisk-storage-details-wide-chromium-linux.png | Adds wide-layout Chromium snapshot for VDisk storage details. |
| tests/suites/storage/vdiskPage.test.ts-snapshots/vdisk-storage-details-narrow-chromium-linux.png | Adds narrow-layout Chromium snapshot for VDisk storage details. |
| tests/suites/storage/vdiskPage.test.ts-snapshots/vdisk-storage-details-medium-safari-linux.png | Adds medium-layout Safari snapshot for VDisk storage details. |
| tests/suites/storage/vdiskPage.test.ts-snapshots/vdisk-storage-details-medium-chromium-linux.png | Adds medium-layout Chromium snapshot for VDisk storage details. |
| tests/suites/storage/vdiskPage.test.ts | Adds E2E coverage for storage details rendering, PDisk navigation, and table rendering in VDisk context. |
| src/store/reducers/vdisk/utils.ts | Populates NodeRack in the prepared VDisk response. |
| src/store/reducers/vdisk/types.ts | Extends VDiskData with optional NodeRack. |
| src/store/reducers/vdisk/tests/prepareVDiskDataResponse.test.ts | Verifies prepareVDiskDataResponse includes NodeRack from node system state. |
| src/containers/VDiskPage/VDiskStorageDetails.tsx | New UI component rendering storage usage metrics + location details + PDisk link. |
| src/containers/VDiskPage/VDiskStorageDetails.scss | Styles for the new storage details card layout and truncation/popovers. |
| src/containers/VDiskPage/VDiskPage.tsx | Renders storage details on the VDisk page when the experiment is enabled. |
| src/containers/VDiskPage/VDiskPage.scss | Adds spacing for the new storage details block. |
| src/containers/VDiskPage/i18n/en.json | Adds i18n strings for the new storage details UI. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f29b25d33a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| padding-right: var(--g-spacing-4); | ||
| } | ||
|
|
||
| &__metric_usage { |
Stand
Closes #3732
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ✨4
✨ New Tests (4)
Bundle Size: 🔺
Current: 63.42 MB | Main: 63.39 MB
Diff: +0.02 MB (0.04%)
ℹ️ CI Information