This repository was archived by the owner on Aug 16, 2024. It is now read-only.
use pointer when load ffm model and release model with Explicit method #26
Open
Imagle wants to merge 1 commit intoycjuan:masterfrom
Open
use pointer when load ffm model and release model with Explicit method #26Imagle wants to merge 1 commit intoycjuan:masterfrom
Imagle wants to merge 1 commit intoycjuan:masterfrom
Conversation
Imagle
commented
Jan 17, 2018
- Release model(W) not in destructor method.
- Not to use ffm_load_model, because this method return a object which is local variables, when it returned, it will call destructor(~ffm_model()), and W will be freed.
- Add a new method(ffm_load_model_ptr) which return a pointer to the model.
- Add a new class method of ffm_model--release, which is used to free model in explicit way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.