refactor(filter): 优化DiffFilter中类路径处理逻#28
Closed
kangjie0603 wants to merge 2 commits intoyangziwen:masterfrom
Closed
refactor(filter): 优化DiffFilter中类路径处理逻#28kangjie0603 wants to merge 2 commits intoyangziwen:masterfrom
kangjie0603 wants to merge 2 commits intoyangziwen:masterfrom
Conversation
kangjie0603
commented
Dec 4, 2025
kangjie0603
commented
- 简化模块路径处理方式，支持多级子模块，直接查找/src/main/java/位置来获取类相对路径
added 2 commits
December 4, 2025 17:31
- 简化模块路径处理方式，支持多级子模块，直接查找/src/main/java/位置来获取类相对路径
- 简化模块路径处理方式，支持多级子模块，直接查找/src/main/java/位置来获取类相对路径
yangziwen
reviewed
Dec 6, 2025
|
|
||
| // 直接查找 /src/main/java/ 的位置，支持任意深度的嵌套模块 | ||
| // 这种方式比逐级去除路径段更高效，且逻辑更清晰 | ||
| int srcIndex = name.indexOf(SOURCE_PATH_PREFIX); |
Owner
There was a problem hiding this comment.
在文件路径中寻找/src/main/java/片段，和按pom文件中的标签中声明的内容寻找子模块是有本质区别的。此处应该严格按pom中声明的模块处理相关逻辑。
Author
There was a problem hiding this comment.
这里有个问题：插件配置到 root pom 时， 各子模块不会再执行添加的filtler （标记已经执行过了）， 如果子模块下还有子模块，当前fitler 获取的模块不包含子模块的子模块，最后map key的路径是包含 模块路径的，与getClassPath 路径不一致导致无效。 PersonFilte 同理
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.