perf(linguist): SymbolizeBatch — O(n)→O(miss) eBPF syscalls via 2-pass LRU+map scan#96
Open
KorsarOfficial wants to merge 1 commit intoyandex:mainfrom
Open
perf(linguist): SymbolizeBatch — O(n)→O(miss) eBPF syscalls via 2-pass LRU+map scan#96KorsarOfficial wants to merge 1 commit intoyandex:mainfrom
KorsarOfficial wants to merge 1 commit intoyandex:mainfrom
Conversation
ce51811 to
1b2a09e
Compare
Author
|
Closing to verify the implementation compiles correctly with ya build before resubmitting. Will reopen once the build is confirmed. |
Author
|
Reopening after verification: the two core packages compile clean under |
Author
|
📄 Full analysis report (PDF): 08-perforator-optimizations.pdf Covers complexity analysis, concurrency audit, and verification for all 7 optimizations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #91
Complexity analysis
Let n = stack depth, h = LRU cache hit rate ∈ [0, 1].
Lookupcalls per sampleAt steady state h ≈ 0.9 (typical LRU retention for hot frames):
For n = 64 frames: −57 eBPF round-trips per sample.
Implementation
Two-pass symbolization:
Pass 1 — O(n) LRU sweep, 0 syscalls:
Pass 2 — O(|missIdx|) individual
BPF_MAP_LOOKUP_ELEMcalls:Note:
BPF_MAP_TYPE_LRU_HASHdoes not support kernel-levelBPF_MAP_LOOKUP_BATCHfor arbitrary key sets — per-keyLookupis the correct and only approach for targeted resolution.Files changed
programstate/lang.goSymbolizeInterpreterBatch(keys []SymbolKey) → ([]Symbol, []bool)symbolizer/symbolizer.godecodeSymbol(extracted helper), +SymbolizeBatch(2-pass)profiler/stack_processor.goSymbolizeBatch→ build profile in second passBackwards-compatible;
Symbolize(single-key path) is unchanged.