feat: Add CiDetectedErrorFormatter for improved error output in GitHub and TeamCity while using the friendly formatter#40
Conversation
Summary of ChangesHello @marcreichel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the utility of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for CI-specific error formatting by integrating CiDetectedErrorFormatter. This is a great addition for better integration with CI systems like GitHub Actions and TeamCity. The implementation correctly injects the new formatter and calls it to produce the CI-specific output.
My main feedback is regarding testing. The new functionality is not currently covered by tests. I've left a suggestion in the test file to add tests that verify the output in simulated CI environments. This will ensure the feature works as expected and prevents future regressions.
Overall, a good feature addition. Addressing the testing gap will make it solid.
|
@yamadashy Let me know if I should add a test as @gemini-code-assist suggested. But in my opinion a test for this is unnecessary, because it's a feature coming from PHPStan and the test here may break in the future eventually if PHPStan changes the implementation/output. |
|
Hi @marcreichel ! Thanks for the first PR! |
…b and TeamCity while using the friendly formatter
930304a to
d4b7c8f
Compare
…test - Add service definitions for GithubErrorFormatter, TeamcityErrorFormatter, and CiDetectedErrorFormatter in extension.neon - Fix testSummaryShowsSpecialIdentifierNotes to pass CiDetectedErrorFormatter parameter to FriendlyErrorFormatter constructor
|
@marcreichel Everything else looks good, so I'll merge this. Will release soon! |
This PR adds the CiDetectedErrorFormatter so the output includes the relevant annotations for GitHub or TeamCity based on the detected environment while still being able to use the friendly formatter in CI pipelines.