XWIKI-23958: Inconsistency in the notification userlink

[Sereza7]

Jira URL

https://jira.xwiki.org/browse/XWIKI-23958

Changes

Description

• Fixed the inconsistency by updating the code of the specific macro.
• (unrelated to the PR topic) Removed a now useless styleblock.

Clarifications

• I decided to not bring the feature of onlyAvatar to the standard macro but keep it hard-coded there, since it doesn't look like it'd be useful in other places. If we ever use it in another place, then it'd be interesting.
• XWIKI-22269 was fixed in 16.8, so it's high time to remove that CSS ruleblock. I could not see a change on my local instance when removing it.

Screenshots & Video

Before the PR:


After the PR:

Executed Tests

Semi-automated accessibility test on the new notification macro found on the profile (see screenshot above). Somehow axe-core doesn't identify this link as an inline link so it doesn't trigger a contrast violation.

Built the changes successfully with mvn clean install -f xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/ -Pquality.

Ran docker tests: mvn clean install -f xwiki-platform-core/xwiki-platform-mentions/xwiki-platform-mentions-test/xwiki-platform-mentions-test-docker/
Those use

xwiki-platform/xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-test/xwiki-platform-notifications-test-pageobjects/src/main/java/org/xwiki/platform/notifications/test/po/GroupedNotificationElementPage.java

Line 94 in 8da5c63

WebElement emitter = notifications.findElements(cssSelector(EMITTER_SELECTOR)).get(groupIndex);

which could have broken with the changes.

Expected merging strategy

• Prefers squash: Yes
• Backport on branches:
  • 17.10.X (pretty safe bugfix with a low scope)

[github-actions]

💚 All backports created successfully

Status	Branch	Result
✅	stable-17.10.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details