XWIKI-19779: Bad display of non-viewable users in the likers page#5057
XWIKI-19779: Bad display of non-viewable users in the likers page#5057Sereza7 wants to merge 3 commits intoxwiki:masterfrom
Conversation
* Removed the two custom macro definitions from likers.vm and getusers.vm * Introduced a (non API) alternative directly in the global velocity macros in macros.vm * Added an option to the displayUser macro to account for the one thing that was missing.
* Removed the two custom macro definitions from likers.vm and getusers.vm * Introduced a (non API) alternative directly in the global velocity macros in macros.vm * Added an option to the displayUser macro to account for the one thing that was missing.
mflorea
left a comment
mflorea
left a comment
There was a problem hiding this comment.
Displaying "XWikiGuest" is very confusing. We cannot fix the "bad display of non-viewable users" by showing incorrect information. Moreover, I don't understand how you can have "User: XWikiGuest" and "First Name: Administrator" on the second row of your screenshot. How can you have access to the first name but not the user reference?
the users that doesn't have rights sees "Guest user" with links pointing towards the pages they don't have access to.
If you have the link to the user profile page then I assume you have the user reference. If you have the user reference then why display "XWikiGuest" instead of the user alias (user reference name)?
The way I see it, there are two cases:
- You have access to the user reference but not the user profile page => you should display the user alias (user reference name), linked to the user profile page (you can obtain the URL from the user reference). The First Name and Last Name columns should be empty, because you need access to the user profile to get this information.
- You don't have access to the user reference, i.e. the user reference is
null=> in this case the user displayer can display "XWikiGuest" without any link, but IMO an API that returns a list of user references with null values has a design problem (it should filter out those null values).
My understanding is that you are in the first case, otherwise you wouldn't have the link to the user profile page.
This is the standard way to handle user display when the current user doesn't have view permission (IMO it could be better, but it's not the point of the ticket)
I don't agree. As an end user I don't care how the code is organized under the hood to reduce duplication. I expect the UI to provide useful and accurate information.
| ## We avoid the whitespace because the users are displayed as inline blocks. | ||
| #set ($discard = $output.addAll([ | ||
| "<$userTag class=""$type"" data-reference=""$escapetool.xml($userReference)"">", | ||
| "<$userTag class=""$userClasses"" data-reference=""$escapetool.xml($userReference)"">", |
There was a problem hiding this comment.
| "<$userTag class=""$userClasses"" data-reference=""$escapetool.xml($userReference)"">", | |
| "<$userTag class=""$escapetool.xml($userClasses)"" data-reference=""$escapetool.xml($userReference)"">", |
2 participants
Jira URL
https://jira.xwiki.org/browse/XWIKI-19779
Changes
Description
Clarifications
Screenshots & Video
After the PR:
The
getusers.vmtemplate still works as intended.I liked the page with two accounts. The administrator sees both as expected, and the users that doesn't have rights sees "Guest user" with links pointing towards the pages they don't have access to. This is the standard way to handle user display when the current user doesn't have view permission (IMO it could be better, but it's not the point of the ticket.)
Executed Tests
Manual tests on local instance, see above.
Successfully built changes with:
mvn clean install -f xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-api -Pqualitymvn clean install -f xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates -PqualityExpected merging strategy