Open
Conversation
c15cd83 to
dcf3ed1
Compare
dcf3ed1 to
ef48176
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've received mixed feedback on when I should submit changes, but I've changed a lot already, so I figure I'll submit what I have now.
Changes include:
mentions->typeand is now required (since we aren't using refs)jid/occupantid/uri->targetfor consistencybegin/endare now mandatory and hopefully more clear what they dohreflangin favour ofxml:lang<noping />since no one wanted itactivea boolean attribute since I don't see a use for any other modifierstypewithtargetcontaining the role/affiliationmuc#roomconfigand servers MUST act based on itbegin/endif sentAs with the initial submission, I have an example Slixmpp plugin in Python located here.