XEP-0167: Make the schema tighter around bandwidth#1496
Open
linkmauve wants to merge 1 commit intoxsf:masterfrom
Open
XEP-0167: Make the schema tighter around bandwidth#1496linkmauve wants to merge 1 commit intoxsf:masterfrom
linkmauve wants to merge 1 commit intoxsf:masterfrom
Conversation
The set of bandwidth types are known and constrained, and the value isn’t a string but an integer. I couldn’t find limits for said integer, but given it can be kb/s or b/s I went for an unsigned 32-bit integer, as that can represent up to 4 Gib/s (512 MiB/s), which should be enough for anybody™.
github-actions
bot
added
the
Needs Council
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The set of bandwidth types are known and constrained, and the value isn’t a string but an integer. I couldn’t find limits for said integer, but given it can be kb/s or b/s I went for an unsigned 32-bit integer, as that can represent up to 4 Gib/s (512 MiB/s), which should be enough for anybody™.