fix: correct get_context_length default fallback behavior#4861
Open
Ricardo-M-L wants to merge 1 commit intoxorbitsai:mainfrom
Open
fix: correct get_context_length default fallback behavior#4861Ricardo-M-L wants to merge 1 commit intoxorbitsai:mainfrom
Ricardo-M-L wants to merge 1 commit intoxorbitsai:mainfrom
Conversation
When all config attributes (max_sequence_length, seq_length, max_position_embeddings) are None, the function incorrectly returned 2048 even though max() with all None values would raise ValueError. Now uses a generator expression with default parameter to properly handle the case where no values are available. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
|
There is conflict, please resolve it. |
Contributor
|
This logic has been modified in #4768 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct get_context_length default fallback behavior to properly handle cases where context length is not explicitly set.
🤖 Generated with Claude Code