Maintenance: several updates - #64
Merged
Merged
Conversation
nahoj
marked this pull request as draft
April 26, 2026 17:25
nahoj
changed the title
nahoj
marked this pull request as ready for review
April 26, 2026 19:45
Contributor
Author
|
I also wonder if it makes sense that the minimum xonsh version be 0.12.5 given how much change there must have been since then. |
anki-code
self-requested a review
April 26, 2026 20:01
anki-code
approved these changes
Apr 26, 2026
Member
|
Thanks @nahoj ! |
Contributor
Author
|
@anki-code You're welcome, what do you think of the xonsh version requirement? |
Member
|
0.12.5 is totally outdated let's use 0.23.0 to push everything forward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change I'm least sure about is bumping the minimum Python version. I'm not sure what the policy is. But 3.8/9 don't pass CI after
pre-commit autoupdatepins mypy to 1.20.Several CI actions warned that they
actions/cache@v3still does but is pulled bypre-commit/action@v3.0.0which itself is deprecated. I don't know how to resolve this.Claude justification for removing
types-all.▎ types-all is a meta-package that depends on types-pkg-resources, which has been removed from PyPI
▎ (its stubs were merged into types-setuptools). Installing the mypy hook fails with No matching
▎ distribution found for types-pkg-resources.
▎
▎ Since the hook already passes --ignore-missing-imports, no replacement is needed. Projects that
▎ need specific stubs can add them as additional_dependencies themselves (e.g. types-requests).